Report pagination is nearly invisible

Bug #1466462 reported by John-Magne Bredal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Network Administration Visualized
Fix Released
Wishlist
John-Magne Bredal

Bug Description

Pagination in the report system consists of a simple "next page / prev page", marked by double angle brackets, which are nearly invisible.

Also, the default page size is the ridiculously high value of 1000.

Even though paging is a symptom of a report that is too large, more visible paging, with page indexes, should be implemented.

Revision history for this message
John-Magne Bredal (john-m-bredal) wrote :

Fix here:
https://nav.uninett.no/hg/default/rev/48cde6d4f891

Improvements added since then

Changed in nav:
milestone: none → 4.4.0
assignee: nobody → John-Magne Bredal (john-m-bredal)
status: New → Fix Committed
summary: - report pagination
+ Report pagination is nearly invisible
description: updated
Changed in nav:
importance: Undecided → Wishlist
Revision history for this message
Morten Brekkevold (mbrekkevold) wrote : Re: [Bug 1466462] Re: report pagination

On Fri, 19 Jun 2015 09:38:11 +0000 John-Magne Bredal <email address hidden> wrote:

> Fix here:
> https://nav.uninett.no/hg/default/rev/48cde6d4f891

I have tested the current development branch, and I have a few comments.

The new paging UI elements look good, but:

1. The original default page size of Report was 100. At some point, this
   was changed to 1000. This change reduces the page size to 25, which
   is probably _not_ what the nav-ref members were expecting out of
   this. Personally, I find 25 to be too little, 100 to be adequate, and
   1000 is ludicrous.

2. The page size used to be configurable, via the `limit` query
   argument. However, with these changes, adding a `limit` query
   argument will, in fact, limit the report as a whole to this number of
   rows, which is quite unexpected, and undesired.

   By guessing and subsequently testing, it would seem the `page_size`
   query argument has been introduced, which produces the expected
   behavior.

   There is no obvious way to actually set the page size, though. To be
   consistent with other paging UIs in NAV 4, this should probably be
   added as a dropdown selection, and stored as part of the user's
   preferences (localstorage or whatever mechanism is used elsewhere in
   NAV).

Revision history for this message
John-Magne Bredal (john-m-bredal) wrote :

Page size is now selectable in a drop down, and the preference is stored for the account.

Changed in nav:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers