Parsing of sensors with names that contains #

[Øystein Gyland]

The Cisco Industrial Ethernet 2000 series have temperature sensors with names that contains the '#' sign;

$ snmpget -c community -On -v2c switch .1.3.6.1.4.1.9.9.13.1.3.1.2.1006
.1.3.6.1.4.1.9.9.13.1.3.1.2.1006 = STRING: "SW#1, Sensor#1, GREEN "

I guess that the problems caused by this is somewhat similar with the problems related to the ',' character fixed earlier in the 4.2 series?

It appears that ipdevpoll collects data from the switch and that the corresponding whisper-file is populated as expected.
Graphite displays the data as expected while the ipdevinfo page in NAV displays an empty graph with the text "No data". I reckon that NAV somehow fails to open the whisper file? By the way, the "name" and "internal_name" values in the sensor table is "SW#1, Sensor#1, GREEN" despite the 4.2 patch to remove ',' characters from sensor names.

-Øystein

[John-Magne Bredal (john-m-bredal)]

The hash mark (#) has a meaning in urls - http://en.wikipedia.org/wiki/Fragment_identifier . Thus when it appears it (among other special characters) needs to be escaped.

As you try to view a graph in IpDeviceInfo the graph is fetched when you click. The timespan is appended to a base url, so that the correct graph is fetched. The hash mark created an error in this process.

Thanks for noticing, and even more for creating a bug report for it!

[John-Magne Bredal (john-m-bredal)]

Fix here:
https://nav.uninett.no/hg/stable/rev/d9cf9ad43068

but include https://nav.uninett.no/hg/stable/rev/e78f09e96f45 after.

[Morten Brekkevold (mbrekkevold)]

I'd like to add that this is not related to the comma issue, described by the reporter.

The comma is a legal character in metric names, but the comma has specific meaning when building graphite-web graph targets, and there is no meaningful way to quote the commas when building graph targets. This is why commas were added to the list of characters that will be replaced by underscores when metric names are generated by NAV.

The *actual* name of a sensor still contains commas - only the corresponding metric files created by Carbon/Graphite will have them replaced by underscores. Also, NAV doesn't open whisper files; they are entirely handled by Graphite. NAV only asks the graphite webapp to retrieve the data it needs, either as raw numbers or rendered graphs.