Some routers fail to expand in Network Explorer

[Morten Brekkevold]

Under NAV 4.2.1 (and possibly back to 4.0), not all routers will expand when the adjacent plus icon is clicked in Network Explorer.

For the end user, the symptom is that the plus icon changes into a spinner icon that never stops. Opening the browser developer tools show that an AJAX request is failing in a 500 Internal Server Error, which is not being reported back to the end user.

The traceback mailed from Django to the site admin looks like this:

Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/django/core/handlers/base.py", line 109, in get_response response = callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.7/dist-packages/django/views/generic/base.py", line 48, in view return self.dispatch(request, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/django/views/generic/base.py", line 69, in dispatch return handler(request, *args, **kwargs)
File "/usr/lib/python2.7/dist-packages/django/views/generic/detail.py", line 99, in get context = self.get_context_data(object=self.object)
File "/usr/lib/python2.7/dist-packages/nav/web/networkexplorer/mixins.py", line 99, in get_context_data 'trunk_port': gwport.to_interface.trunk,
AttributeError: 'NoneType' object has no attribute 'trunk'

[Morten Brekkevold (mbrekkevold)]

Seems like a simple failure to verify that an interface's neighboring interface is actually known (sometimes the neigboring device is known, but not the interface of the neighboring device). Should be a relatively easy fix.

[Morten Brekkevold (mbrekkevold)]

fix here: https://nav.uninett.no/hg/stable/rev/4459c0ce76c1