zoom slider click behavior

[zpletan]

I am using nautilus 1:2.30.1-0ubuntu5~ppa46 (nautilus-elementary from ppa:am-monkeyd/nautilus-elementary-ppa) - and it's awesome! I have, however, a problem with the zoom slider in the bottom right of the interface. When clicking the trough to move the slider along, there are only two settings, tiny and huge. Clicking the trough should increment the zoom size by a more granular amount, or move the slider to the point clicked. The current behavior can be rather annoying, as any other current way of changing the zoom level is not nearly as fast or easy.

[ammonkey (am-monkeyd)]

1) what you describe here is exactly the behavior of the zoom_slider: there is 7 zoom positions, the slider is 100 pixel width, it means each 14 pixels you change the zoom lvl. 14 pixels is what you're calling far?
You can scroll on the zoom_slider too, just put the mouse over it and scroll, then it increment or decrement zoom, I find it much sleeker to change my zoom lvl this way.

1)+2) in a perfect world the zoom should be implemented differently. Implementing the zoom with some fixed zoom lvls is really a bad choice. It doesn't feel natural at all. But we have to deal with that for the moment, as the view are implemented this way in stock nautilus. So until we change the views we have to deal with that.

maybe you should open a bug in bugzilla about the fixed zoom level in nautilus, and link them this note ;)
http://live.gnome.org/User%20Interface%20Patterns/Zooming

[zpletan (zpletan)]

1) If you can scroll to move the slider a set amount, why shouldn't you be able to click to the left/right of it to do the same thing?

1)+2) I agree with your conclusions regarding preset levels (and would personally love to see the fine-grained zoom), but either a) the slider needs to get synced with the preset zoom levels, or b) the zoom levels need to get fixed so that the zoom is finer-grained.

I can't file a bug in upstream nautilus because the problem does not exist there - it has zoom in/out buttons and a menu w/ all the zoom levels. This behavior does exist in nautilus-elementary because nautilus-elementary has the slider.

[ammonkey (am-monkeyd)]

1) actually what we called zoom slider is a gtk_hscale widget when u click on it, it select the position where u clicked. It's exactly the same behavior as other gtk_hscale used in totem rhytmbox... If i clearly understand what you want is: when u click on an extremity of the horizontal scale widget instead of directly go on the resquested position it increments or decrements the zoom value? Is that the behavior u suggest?

[zpletan (zpletan)]

Now I understand what you were getting at. My problem (at least one of them; I will file a separate bug on the other one) is that when I click the trough outside the actual slider, the slider moves to the extreme end of the trough, rather than a) incrementing the slider along the trough, or b) positioning the slider where I clicked. Either of these fixes will be just fine (and frankly, given the above discussion on set zoomlevels, makes more sense). I am also marking this bug as incomplete, since my changes pretty basically affected the bug.

[ammonkey (am-monkeyd)]

ok i understand your bug now ;), clicking on the scale does not work as expected: it goes to one the 2 extremities without going to others positions. thx for the bug report.

[Alexandr Grigorcea (cahr-gr)]

kitkat, there is a hack to fix that
you need to catch the click on slider and change the button number from 1 to 2 and return FALSE, this will imitate middle click behavior (as I understand this is what you need)

[Alexandr Grigorcea (cahr-gr)]

ah, and you need to do the same with release event
http://pastebin.com/WMjuVVnz

[ammonkey (am-monkeyd)]

you're right Alexandr, seems the middle button works ok so yes simulating the click as a middle click can work. Or implementing normal click and give the position value of the click to the gtk_range widget can work too. Didn't have much time to look into this.

Thx for the idea/code Alexandr.