Open Terminal Here does not honour x-terminal-emulator alternative

Bug #1085809 reported by Ivan Wirawan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nautilus-actions-extra
Won't Fix
Medium
Dr. Amr Osman

Bug Description

The Open Terminal Here does not honour x-terminal-emulator alternative, instead it is hard-coded to gnome-terminal.

I would like to propose the following patch to make the Open Terminal Here action honour x-terminal-emulator:

--- /usr/share/nautilus-python/extensions/open-terminal-here.py 2012-12-03 14:11:30.000000000
+++ /usr/share/nautilus-python/extensions/open-terminal-here.py 2012-11-18 00:46:09.000000000
@@ -17,13 +17,13 @@
         path=urllib.url2pathname(url[7:])
         return path

     def terminal(self, menu,path):
         curpath="%s"%path
- bash_string=["gnome-terminal","--geometry",'100x25',"--working-directory",curpath]
+ bash_string=["x-terminal-emulator","--geometry",'100x25',"--working-directory",curpath]
         subprocess.Popen(bash_string)

     def get_file_items(self, window, files):
         if len(files) != 1:
             return

I hope this help.

Revision history for this message
Dr. Amr Osman (dr3mro) wrote :

I will fix that soon I promise
thank you

Changed in nautilus-actions-extra:
assignee: nobody → Dr. Amr Osman (dr3mro)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Dr. Amr Osman (dr3mro) wrote :

Ok I found a problem
x-terminal-emulator wont pass the current path variable to the terminal emulator .. if you have another FIX that will cause a custom terminal and respect the current path give me a patch and i will add it

Changed in nautilus-actions-extra:
status: In Progress → Won't Fix
status: Won't Fix → In Progress
Dr. Amr Osman (dr3mro)
Changed in nautilus-actions-extra:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.