innodb_recover ignores relpath

[Brian Evans]

The innodb_recover option ignores the relpath option which makes the recovery in the wrong place in the snapshot.

The Innodb files are created in $mountdir instead of recovering $mountdir/$relpath

[Lenz Grimmer (lenzgr)]

That is true - I tried to document this in the man page, but probably need to add the relpath option to this as well:

"Note that this functionality currently assumes the default InnoDB configuration - it does not work properly if you use options like --innodb-file-per-table, --innodb-data-home-dir, --innodb-data-file-path or --innodb-log-group-home-dir that modify the default file layout for InnoDB tables."

To fix this we would have to parse the my.cnf file for these options and take them into account. This is currently not implemented, but patches are always welcome :)

[Brian Evans (grknight-scent-team)]

From my understanding, the relpath option is:
"Relative path on the logical volume to the MySQL data directory."

As such, when the innodb_recover option is used, relpath must be taken into account.

A sample structure:
LV = /var/mysql
data-directory = /var/mysql/instance
mountpath=/var/tmp/mylvmbackup/mnt/backup
relpath=instance

mylvmbackup would snapshot /var/mysql, but incorrectly set the innodb_recovery --data-directory to /var/tmp/mylvmbackup/mnt/backup instead of /var/tmp/mylvmbackup/mnt/backup/instance

[Lenz Grimmer (lenzgr)]

My bad, I confused "relpath" with an InnoDB configuration option! I will take another look at this.

[Lenz Grimmer (lenzgr)]

OK, I've now pushed a fix for this bug into the trunk, it will be part of the next release (0.13). Thanks for the report!