mylvmbackup

backup returns successfully when snapshot creation fails

  1. Series trunk
  2. Bug #267944
Bug #267944 reported by Jonas
2
Affects Status Importance Assigned to Milestone
mylvmbackup
Status tracked in Trunk
Trunk
Fix Released
Medium
Lenz Grimmer

Bug Description

When snapshot creation fails (say, dm_snapshot isn't loaded, etc) the overall script still finishes with a return value of 0 - it should instead fail gracefully.

Attached is a patch against the version 0.9 release which adds an else clause to the if ($snapshot_created) statement.

Related branches

lp:mylvmbackup
Revision history for this message
Jonas (jonas-bravenet) wrote :
Revision history for this message
Lenz Grimmer (lenzgr) wrote :

Thanks for the patch! Good point - the script currently is quite optimistic and does not cover many failure cases yet.
I'll take a look at this and will integrate it for the next release.

Changed in mylvmbackup:
assignee: nobody → lenzgr
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Lenz Grimmer (lenzgr) wrote :

A fix for this has now been commited to the trunk. Please test!

Changed in mylvmbackup:
status: Confirmed → Fix Committed
Revision history for this message
Matthew (mboehm) wrote :

add a hook!!!
if it fails it should run a hook script so that it can send an email or whatever to notify admin.

Revision history for this message
Lenz Grimmer (lenzgr) wrote :

This bug was fixed in release 0.11.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.