rsnap backuptype should allow passing arguments to rsync

Bug #403177 reported by Maciej Dobrzanski
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
mylvmbackup
Fix Released
Medium
Lenz Grimmer

Bug Description

rsnap is only a wrapper script and so essentially all the work is performed by rsync. Currently mylvmbackup allows creating backups using rsnap, however there is no ability to control rsync from the configuration file (e.g. to set such useful option like --bwlimit) which is probably an oversight. The fix is simple, just add:

$command .= " -- $rsyncarg" if $rsyncarg ne "";

to do_backup_rsnap() at the very end of the command string building.

The only concern is that rsyncarg should probably not carry any parameters unless they are set explicitly in the configuration when rsnap is used (i.e. the default value should be empty).

Maciek

Revision history for this message
Lenz Grimmer (lenzgr) wrote :

Agreed, adding this option sounds useful. I will likely have to create an additional configuration option for this, as "rsyncarg" is already used by the rsync backup module.

Changed in mylvmbackup:
assignee: nobody → LenZ (lenzgr)
importance: Undecided → Medium
milestone: none → 0.14
status: New → Confirmed
Revision history for this message
Lenz Grimmer (lenzgr) wrote :

A patch for this has been committed to the trunk a while ago already

Changed in mylvmbackup:
status: Confirmed → Fix Committed
Lenz Grimmer (lenzgr)
Changed in mylvmbackup:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers