rsnap backuptype should allow passing arguments to rsync

[Maciej Dobrzanski]

rsnap is only a wrapper script and so essentially all the work is performed by rsync. Currently mylvmbackup allows creating backups using rsnap, however there is no ability to control rsync from the configuration file (e.g. to set such useful option like --bwlimit) which is probably an oversight. The fix is simple, just add:

$command .= " -- $rsyncarg" if $rsyncarg ne "";

to do_backup_rsnap() at the very end of the command string building.

The only concern is that rsyncarg should probably not carry any parameters unless they are set explicitly in the configuration when rsnap is used (i.e. the default value should be empty).

Maciek

[Lenz Grimmer (lenzgr)]

Agreed, adding this option sounds useful. I will likely have to create an additional configuration option for this, as "rsyncarg" is already used by the rsync backup module.

[Lenz Grimmer (lenzgr)]

A patch for this has been committed to the trunk a while ago already