mylvmbackup

mylvmbackup will exit(0) even when commands fail

Bug #298175 reported by Kjetil Torgrim Homme on 2008-11-14

Affects		Status	Importance	Assigned to	Milestone
	mylvmbackup	Fix Released	Medium	Lenz Grimmer	mylvmbackup 0.11
Nominated for Trunk by almhajr

Bug Description

Here's a patch (relative to today's trunk) which will make mylvmbackup a lot more paranoid, ie. it will exit as soon as a LOG_ERR is encountered. Better to exit early so that the user isn't mislead :-)

I hope you will accept it. Thank you for mylvmbackup!

Related branches

lp:mylvmbackup

Revision history for this message

Kjetil Torgrim Homme (kjetilho) wrote on 2008-11-14:

paranoia patch Edit (9.5 KiB, text/plain)

Revision history for this message

Lenz Grimmer (lenzgr) wrote on 2008-11-20:

Thanks for the patch! Good suggestion, I will look into this.

Changed in mylvmbackup:
assignee:	nobody → lenzgr
importance:	Undecided → Medium
milestone:	none → 0.11
status:	New → In Progress

Lenz Grimmer (lenzgr) on 2008-11-20

Changed in mylvmbackup:
status:	In Progress → Fix Committed

Revision history for this message

Lenz Grimmer (lenzgr) wrote on 2008-11-20:

I now commited and pushed your patch with slight modifications to the trunk. It will be part of the upcoming 0.11 release. Thanks for your contribution!

Revision history for this message

Lenz Grimmer (lenzgr) wrote on 2008-11-24:

This bug was fixed in release 0.11. I had to slightly change the handling of comparing the severety levels.