backup returns successfully when snapshot creation fails
Bug #267944 reported by
Jonas
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
mylvmbackup | Status tracked in Trunk | |||||
Trunk |
Fix Released
|
Medium
|
Lenz Grimmer |
Bug Description
When snapshot creation fails (say, dm_snapshot isn't loaded, etc) the overall script still finishes with a return value of 0 - it should instead fail gracefully.
Attached is a patch against the version 0.9 release which adds an else clause to the if ($snapshot_created) statement.
Related branches
To post a comment you must log in.
Thanks for the patch! Good point - the script currently is quite optimistic and does not cover many failure cases yet.
I'll take a look at this and will integrate it for the next release.