backup returns successfully when snapshot creation fails

Bug #267944 reported by Jonas on 2008-09-08
2
Affects Status Importance Assigned to Milestone
mylvmbackup
Status tracked in Trunk
Trunk
Medium
Lenz Grimmer

Bug Description

When snapshot creation fails (say, dm_snapshot isn't loaded, etc) the overall script still finishes with a return value of 0 - it should instead fail gracefully.

Attached is a patch against the version 0.9 release which adds an else clause to the if ($snapshot_created) statement.

Related branches

Lenz Grimmer (lenzgr) wrote :

Thanks for the patch! Good point - the script currently is quite optimistic and does not cover many failure cases yet.
I'll take a look at this and will integrate it for the next release.

Changed in mylvmbackup:
assignee: nobody → lenzgr
importance: Undecided → Medium
status: New → Confirmed
Lenz Grimmer (lenzgr) wrote :

A fix for this has now been commited to the trunk. Please test!

Changed in mylvmbackup:
status: Confirmed → Fix Committed
Matthew (mboehm) wrote :

add a hook!!!
if it fails it should run a hook script so that it can send an email or whatever to notify admin.

Lenz Grimmer (lenzgr) wrote :

This bug was fixed in release 0.11.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers