binlog dumping can break consistency of the snapshot

Bug #785072 reported by Andrew Hutchings
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Data Dumper
Fix Released
Critical
Andrew Hutchings

Bug Description

Binlog dumping requires the connection to be killed at the end. This means that the consistent snapshot transaction for that connection is broken. Due to the nature of the async queue this can happen in any order.

Two possible ways to fix:

1. Add a sort algorithm to the async queue adding weighting
2. Add a separate thread pool and async queue for binlogs

I'm going to implement 2 due to the nature of the binlog connections (I don't want them anywhere near normal connections) and it will make it easier when continuous binlog dumping is implemented.

Related branches

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

Actually, the async queue is already ordered correctly, the jobs are pushed in the wrong order :(

Changed in mydumper:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.