mydumper erroneously always attempts a dummy read

Bug #1267501 reported by Ben Mildren
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
MySQL Data Dumper
Fix Released
High
Max Bubenick

Bug Description

if (mysql_get_server_version(conn)) {
  mysql_query(conn, "CREATE TABLE IF NOT EXISTS mysql.mydumperdummy (a INT) ENGINE=INNODB");
  need_dummy_read=1;
 }

Looking at the comments on why this code is included it probably should be:

if (mysql_get_server_version(conn) < 40108) {
  mysql_query(conn, "CREATE TABLE IF NOT EXISTS mysql.mydumperdummy (a INT) ENGINE=INNODB");
  need_dummy_read=1;
 }

On most installs the CREATE TABLE... will fail as a ftwrl is acquired just before, but on the current version of Galera (current PXC binaries are 5.5.34 / 5.6.14), the combination of DDL on the same thread that acquired the ftwrl caused the node to go down (https://bugs.launchpad.net/galera/+bug/1265656). Although this was due to a bug that will be fixed, probably best to restrict the CREATE TABLE to only when required.

Related branches

Revision history for this message
Ben Mildren (ben-mildren-8) wrote :
Changed in mydumper:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Max Bubenick (max-bubenick)
Changed in mydumper:
status: In Progress → Fix Committed
Revision history for this message
Daniel Black (daniel-black) wrote :

thanks Ben and Max for the committed patch.

I've pushed it to Debian Bug Tracker: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735851

Changed in mydumper:
milestone: none → 0.6.1
Changed in mydumper:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.