MVHub

pages.t Too Slow

Bug #653188 reported by Keith Fader
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MVHub
In Progress
Medium
Keith Fader

Bug Description

Pages.t executes too slow due to unnecessary repetitive page fetches.

See original description

Related branches

lp:~kfader/mvhub/pages.t-too-slow
Dan MacNeil: Approve
Diff: 448 lines (+99/-33)
6 files modified
app-mvhub/t/bugs/admin_logout_bug.t (+2/-2)
app-mvhub/t/bugs/categorize_link_missing_when_agency_login.t (+6/-8)
app-mvhub/t/bugs/ql_display_agency_home_interaction.t (+4/-3)
app-mvhub/t/bugs/ql_works_after_admin_login.t (+3/-3)
app-mvhub/t/mech/pages.t (+53/-17)
lib-mvhub/t/lib/TestHelper.pm (+31/-0)
Revision history for this message
Keith Fader (kfader) wrote :

Bug fixed.

WWW:Mechanize objects are now cached in @pages hash inside pages.t.
TestHelper::pages_get_ok() fetches pages, responses are cached inside mech objects. Thereafter, since the mech objects are cached in the pages hash, there is no need to ever fetch the pages again.

Test time has now decreased from 60 seconds to 20.

Changed in mvhub:
status: New → Fix Committed
assignee: nobody → Keith Fader (kfader)
description: updated
Dan MacNeil (omacneil)
Changed in mvhub:
status: Fix Committed → In Progress
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.