"Play in music app" fails from My Music scope

[Selene ToyKeeper]

As of krillin rtm image 160, the music app no longer plays a song/album when the user taps "Play in music app" from the My Music scope. This worked in image 159, and I think what changed is that the new music app landed.

This breaks a core feature of the Ubuntu Touch phone.

Instead of playing the requested song, the music app now just shows a list of albums without actually playing anything.

[Selene ToyKeeper (toykeeper)]

After rebooting, this function worked. Looking into the issue a bit further, it looks like the problem was that the "Now playing" screen wasn't working on the first boot. Other functions of the music app worked, but nothing I did was able to cause that screen to come up.

After reflashing 160, I ran into this issue again on first boot. Things which don't work:
- Music scope -> "Play in music app"
- Music app -> "Tap to shuffle music [play]"
- Music app -> random album -> "Play all"
- Music app -> Songs view -> tap any song (does nothing)

Things which do work:
- Music scope -> built-in song preview
- Music app -> random album -> Queue all -> "play" icon at bottom of page

[Selene ToyKeeper (toykeeper)]

FWIW, my attempts so far were:
1. Flash 160, run through sanity tests, fail on music app test.
2. Reboot. Music app worked.
3. Reflash 160, go directly to music test. Fail.
4. Reboot, attempt music test again. Fail.

So, 3/4 tries were a failure. That's reproducible enough I'm failing the sanity tests for image 160.

[I Ahmad (iahmad)]

I am seeing same behaviour, tapping on 'Play All' in music app album view doesn't do any thing niether the play button at the bottom right corner.

[Selene ToyKeeper (toykeeper)]

After a fresh flash, I went directly to the music scope, tapped an artist, tapped a song, then tapped "Play in music app". The music app opened to the album list but did not play anything. Here is the application's log up to that point.

[Selene ToyKeeper (toykeeper)]

If I then tap the first album and then "Play All", nothing appears to happen. The log is longer though, and is attached.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

This looks suspect:-

Debug: Version 2.0
Debug: Arguments on startup: Debug: false
Playlist DB is version
Error reading old playlists, probably doesn't exist.
Error reading old playlists tracks, probably doesn't exist.
DB: Changing version of playlist db to 1.3, migrating 0 tracks
Old playlists []
DB: Restore {}
RECENT does not exist
file:///usr/share/click/preinstalled/com.ubuntu.music/2.0.738/meta-database.js:37: Error: no such table: queue Unable to execute statement

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Tested the attached patch as follows:-

Have music on sd card (so the following wipe won't lose it)
ubuntu-device-flash --channel=ubuntu-touch/ubuntu-rtm/14.09-proposed --revision=160 --wipe
enable developer mode
phablet-shell
touch /userdata/.writable_image
mount -o remount,rw /
add patch (line 36 in /usr/share/click/preinstalled/com.ubuntu.music/2.0.738/meta-database.js)
Navigate to the music scope
Tap artist
Tap album
Tap Play in music app
Music app launches and music plays the queue.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:music-app/remix at revision None, scheduled for release in music-app, milestone music-app-14.10-week-40

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Built a click (attached) after the attached merge landed. Did the following to confirm fix:-

Have music on sd card (so the following wipe won't lose it)
ubuntu-device-flash --channel=ubuntu-touch/ubuntu-rtm/14.09-proposed --revision=160 --wipe
enable developer mode
adb push com.ubuntu.music_2.0.739_all.click /tmp
phablet-shell
pkcon install --allow-untrusted /tmp/com.ubuntu.music_2.0.739_all.click
In music scope:-
Navgiate to artist -> album -> play in music app - music plays
Close music app
Pull down refresh app scope
Launch music app
Wait for music to appear (mediascanner can take a while as I have 8GB music)
Tap play button to shuffle play -> music plays
Tap random album -> play all -> music plays
Tap single track in songs view -> music plays

I believe this fixes the issue in this bug.