music-app should run under confinement under click
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Music App |
Fix Released
|
Medium
|
Andrew Hayzen |
Bug Description
For historical reasons, currently music-app runs unconfined. With media-hub now in place, music-app no longer needs to be unconfined. Because of bug #1303962 and bug #1315381 (lack of apparmor/
{
"policy_
"policy_
"audio",
],
"read_path": [
"/etc/fstab",
"
"
"
"
],
"write_path": [
"
]
}
Once music-app moves away from grilo we can remove the write_path and update read_path accordingly. Once it moves to mediascanner2 and bug #1303962 is fixed in mediascanner2, then read_path can be removed entirely.
Related branches
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Victor Thompson: Approve
-
Diff: 25 lines (+17/-2)1 file modifiedclick/apparmor.json (+17/-2)
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Music App Developers: Pending requested
-
Diff: 692 lines (+290/-231)9 files modifiedMusicPlaylists.qml (+143/-25)
click/apparmor.json (+12/-2)
common/CardView.qml (+0/-1)
common/ColumnFlow.qml (+0/-1)
common/ListItemActions/DeletePlaylist.qml (+29/-0)
common/ListItemActions/EditPlaylist.qml (+35/-0)
common/SongsPage.qml (+0/-131)
po/com.ubuntu.music.pot (+70/-70)
tests/autopilot/music_app/__init__.py (+1/-1)
- Music App Developers: Pending requested
-
Diff: 4986 lines (+1651/-1875) (has conflicts)26 files modifiedMusicAlbums.qml (+21/-123)
MusicArtists.qml (+37/-87)
MusicNowPlaying.qml (+381/-219)
MusicPlaylists.qml (+3/-2)
MusicSettings.qml (+0/-11)
MusicToolbar.qml (+169/-951)
MusicTracks.qml (+14/-15)
MusicaddtoPlaylist.qml (+0/-1)
Player.qml (+5/-1)
Style.qml (+2/-2)
click/apparmor.json (+14/-2)
com.ubuntu.music_music.desktop.in.in (+3/-0)
common/AlbumsPage.qml (+0/-2)
common/BlurredBackground.qml (+11/-9)
common/Card.qml (+151/-0)
common/CardView.qml (+42/-0)
common/ColumnFlow.qml (+159/-0)
common/CoverGrid.qml (+71/-0)
common/MusicPage.qml (+4/-0)
common/MusicRow.qml (+34/-5)
common/SongsPage.qml (+139/-118)
music-app.qml (+24/-33)
po/com.ubuntu.music.pot (+95/-81)
po/pt_BR.po (+111/-84)
tests/autopilot/music_app/__init__.py (+101/-83)
tests/autopilot/music_app/tests/test_music.py (+60/-46)
- Victor Thompson: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 23 lines (+12/-2)1 file modifiedclick/apparmor.json (+12/-2)
Changed in music-app: | |
status: | Fix Committed → Triaged |
Changed in music-app: | |
status: | Triaged → In Progress |
assignee: | Jamie Strandboge (jdstrand) → Andrew Hayzen (andrew-hayzen) |
Changed in music-app: | |
status: | Fix Committed → Fix Released |
I believe we still need to be unconfined until we use background playlists in the media-hub (which is WIP) otherwise next/previous selection will not work when the app is suspended?