Implement bottom edge design for toolbar and Now Playing page using Panel component
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Music App |
Triaged
|
High
|
Unassigned | ||
Bug Description
The music app is a good candidate to do some exploratory work for the bottom edge gesture to reveal the Now Playing page. During the vUDS session by the design team Tim P mentioned [1] that using the Panel component [2] may be the best place to start implementing the bottom edge gesture. There are portions of the music toolbar, such as the hint, that are already implemented by the Panel component. I recommend we attempt to move the music toolbar to the Panel component and attempt to reuse the MusicNowPlaying component/page inside this Panel (allowing the MusicNowPlaying component to also be used as a page/tab if the design dictates doing so).
[1] https:/
[2] https:/
Related branches
- Victor Thompson: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 1961 lines (+745/-1011)3 files modifiedMusicNowPlaying.qml (+8/-15)
MusicToolbar.qml (+737/-993)
music-app.qml (+0/-3)
- Victor Thompson: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Approve
-
Diff: 247 lines (+73/-84)3 files modifiedMusicNowPlaying.qml (+6/-30)
MusicToolbar.qml (+2/-3)
music-app.qml (+65/-51)
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
- Victor Thompson: Needs Fixing
-
Diff: 2815 lines (+1586/-904)10 files modifiedMusicNowPlaying.qml (+15/-4)
MusicToolbar.qml (+1026/-889)
Player.qml (+4/-1)
common/AlbumsPage.qml (+0/-1)
common/MusicPage.qml (+7/-1)
common/PageWithBottomEdge.qml (+512/-0)
common/SongsPage.qml (+1/-1)
music-app.qml (+7/-7)
tests/autopilot/music_app/__init__.py (+6/-0)
tests/autopilot/music_app/tests/test_music.py (+8/-0)
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Needs Information
-
Diff: 385 lines (+152/-11)15 files modifiedapp/components/MusicPage.qml (+45/-4)
app/components/NowPlayingSidebar.qml (+60/-0)
app/components/NowPlayingToolbar.qml (+2/-0)
app/components/Queue.qml (+4/-2)
app/music-app.qml (+29/-3)
app/ui/AddToPlaylist.qml (+1/-0)
app/ui/Albums.qml (+1/-0)
app/ui/ArtistView.qml (+1/-0)
app/ui/Artists.qml (+1/-0)
app/ui/Genres.qml (+1/-0)
app/ui/Playlists.qml (+1/-0)
app/ui/Recent.qml (+1/-0)
app/ui/Songs.qml (+1/-0)
app/ui/SongsView.qml (+3/-2)
debian/changelog (+1/-0)
| Changed in music-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Andrew Hayzen (andrew-hayzen) |
| Changed in music-app: | |
| status: | Triaged → In Progress |
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → In Progress |
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → In Progress |
| Andrew Hayzen (ahayzen) wrote | #3 |
| Changed in music-app: | |
| milestone: | none → 2.0 |
| Changed in music-app: | |
| status: | In Progress → Triaged |
| assignee: | Andrew Hayzen (ahayzen) → nobody |
Fix committed into lp:music-app at revision None, scheduled for release in music-app, milestone 1.0