Genre set to None

Bug #1261925 reported by Adnane Belmadiaf
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Music App
Fix Released
Low
Andrew Hayzen

Bug Description

The genre should be something descriptive when it's not set rather than None.

Related branches

Revision history for this message
Adnane Belmadiaf (daker) wrote :
description: updated
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Do we need to consult design on this?

"Unknown" would be my choice instead of "None".

Revision history for this message
Adnane Belmadiaf (daker) wrote :

+1 for "Unknown" that's what every mediaplayer does.

Andrew Hayzen (ahayzen)
Changed in music-app:
assignee: nobody → Andrew Hayzen (andrew-hayzen)
importance: Undecided → Medium
Andrew Hayzen (ahayzen)
Changed in music-app:
status: New → In Progress
Revision history for this message
Victor Thompson (vthompson) wrote :

We should avoid ranking trivial and mostly subjective bugs so high.

Revision history for this message
Victor Thompson (vthompson) wrote :

I find "Unknown" to be just as undescriptive as "None"--but I agree it's widely used. I just don't like it. The Google Play app groups such tracks into an "Other" category. I'd prefer that if we decide to change.

I think the most important change would be to force whatever we use to either fit in the alphabetic ordering or put it at the end.

Changed in music-app:
importance: Medium → Low
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Agree on the priority, sorry.

At the moment the null items will be at the start of the list due them having a value of "".

Do we have any designers we can consault over the naming?

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

"Unknown" would push it nearer the end of the list of genres in en_GB but may not in other locales?

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

The "Unknown" is pushed to the top currently due to the conversion being done post sorting, I'll try and move it so it is done earlier.

Also there is the discussion whether we should use "Other", "Unknown" or Unknown with a context eg "Unknown Artist" to be resolved.

Revision history for this message
Katie Taylor (katie-t) wrote :

Hello! I'm Katie from the design team.

I think that tracks without a genre should use 'unknown'. And that the tracks with unknown genre should be grouped at the end.

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Katie, thank you for the clarification on the use of "Unknown".

Ok i've changed it so that the conversion is done before sorting, so the "Unknown" tracks are now merged in with tracks already named unknown in alphabetical order.

Do we really want unknown tracks to appear at the end of the list and not in their logical alphabetical position?
If we do, what would we then do with the tracks that are already called "Unknown" do we move them as well, and I also have tracks with data stored as "Other" do we move them as well?
Surely it would be simpler for them to remain in alphabetical order?

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:music-app at revision None, scheduled for release in music-app, milestone 1.0

Changed in music-app:
status: In Progress → Fix Committed
Andrew Hayzen (ahayzen)
Changed in music-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.