TypeError: Unexpected keyword passed to sqlalchemy.orm.session from cf_connections

[Felipe Monteiro]

In both Python 2.7 and 3.4, when calling delete_environment_from_space, a TypeError is thrown, because delete in sqlalchemy.orm.session gets an unexpected keyword argument 'synchronize.' When the keyword is removed, the code correctly executes.

The function prototype for delete in sqlalchemy/orm/session.py is: def delete(self, instance).

The following stacktrace is produced:

Traceback (most recent call last):
  File "/opt/stack/mitaka-murano-gerrit/murano/tests/unit/db/services/test_cf_connections.py", line 177, in test_delete_environmnet_from_space
    cf_connections.delete_environment_from_space(environment.id)
  File "/opt/stack/mitaka-murano-gerrit/murano/db/services/cf_connections.py", line 91, in delete_environment_from_space
    synchronize=False)
TypeError: delete() got an unexpected keyword argument 'synchronize'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/382652

[Felipe Monteiro (fm577c)]

Gerrit link: https://review.openstack.org/#/c/382652/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/382654

[Valerii Kovalchuk (vakovalchuk)]

Please don't change the status by hand, it will change automatically when fix is merged

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/382652
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=9ff3f49f23f9bf40f657e68e2359cf79df047138
Submitter: Jenkins
Branch: master

commit 9ff3f49f23f9bf40f657e68e2359cf79df047138
Author: Felipe Monteiro <email address hidden>
Date: Wed Oct 5 16:33:47 2016 -0400

    Fix TypeError being thrown by delete_environment_from_space
    in cf_connections.

    An unexpected keyword, 'synchronized', is passed to the
    function delete from delete_environment_from_space.
    This fix removes 'synchronized' arg from the call to
    delete.

    Change-Id: I065dc1a81dc0c23cc9a264399a99255e8272b07d
    Closes-Bug: #1630747

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/383875

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/383876

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/383875
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=1627144d367218e4ef94d953395e04fe45caba94
Submitter: Jenkins
Branch: stable/newton

commit 1627144d367218e4ef94d953395e04fe45caba94
Author: Felipe Monteiro <email address hidden>
Date: Fri Oct 7 14:53:35 2016 -0400

    Fix TypeError being thrown by delete_environment_from_space
    in cf_connections.

    An unexpected keyword, 'synchronized', is passed to the
    function delete from delete_environment_from_space.
    This fix removes 'synchronized' arg from the call to
    delete.

    Change-Id: I90cf75f8cfad5afac31e5afe35d82fbddb362bde
    Closes-Bug: #1630747

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/383876
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=c41457aec03df5823d932ea83b40e005bc45ca1b
Submitter: Jenkins
Branch: stable/mitaka

commit c41457aec03df5823d932ea83b40e005bc45ca1b
Author: Felipe Monteiro <email address hidden>
Date: Fri Oct 7 14:55:49 2016 -0400

    Fix TypeError being thrown by delete_environment_from_space
    in cf_connections.

    An unexpected keyword, 'synchronized', is passed to the
    function delete from delete_environment_from_space.
    This fix removes 'synchronized' arg from the call to
    delete.

    Change-Id: Ie8e050a1d1508d9b6429aae7d3a7176a001c92e7
    Closes-Bug: #1630747

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano 3.1.0 release.