Murano

[UI] UI crashes if the UI definition file has no Forms section

  1. Series newton
  2. Bug #1630672
Bug #1630672 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Alexander Tivelkov
Murano 3.1.0
Mitaka
Fix Committed
Medium
Alexander Tivelkov
Murano 2.0.x "2.0.x"
Newton
Fix Committed
Medium
Kirill Zaitsev
Murano 3.0.0
Ocata
Fix Released
Medium
Alexander Tivelkov
Murano 3.1.0

Bug Description

Technically speaking the only mandatory section of the UI definition file is the "Application" block which defines the input object model snippet. Everything else is optional: the app developer may have no user input for their app (besides its name).

However, UI wizard crashes with error if there is no Forms section in the UI definition, but this should not be the case.

Tags: ux
Alexander Tivelkov (ativelkov)
Changed in murano:
assignee: nobody → Alexander Tivelkov (ativelkov)
tags: added: ux
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/382569

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/382574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/382575

Valerii Kovalchuk (vakovalchuk)
Changed in murano:
importance: Undecided → Medium
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/382569
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=2114c2672465ba14bb7b115b2f69f9afe6c6f801
Submitter: Jenkins
Branch: master

commit 2114c2672465ba14bb7b115b2f69f9afe6c6f801
Author: Alexander Tivelkov <email address hidden>
Date: Wed Oct 5 19:52:46 2016 +0300

    'Forms:' section is now truly optional in ui definition

    The only mandatory section of the UI definition file is the
    "Application" block which defines the input object model snippet.
    Everything else is optional: the app developer may have no user input
    for their app besides its name.

    However, the UI was crashing if no 'Forms:' section is present. This
    has been fixed.

    Change-Id: Ie72770a8810369e2bff9a59e8f3845144032f080
    Closes-bug: #1630672

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/mitaka)

Reviewed: https://review.openstack.org/382575
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=7e9aaf20fdae100c97d1f67a18e0e105b90e7a0c
Submitter: Jenkins
Branch: stable/mitaka

commit 7e9aaf20fdae100c97d1f67a18e0e105b90e7a0c
Author: Alexander Tivelkov <email address hidden>
Date: Wed Oct 5 19:52:46 2016 +0300

    'Forms:' section is now truly optional in ui definition

    The only mandatory section of the UI definition file is the
    "Application" block which defines the input object model snippet.
    Everything else is optional: the app developer may have no user input
    for their app besides its name.

    However, the UI was crashing if no 'Forms:' section is present. This
    has been fixed.

    Change-Id: Ie72770a8810369e2bff9a59e8f3845144032f080
    Closes-bug: #1630672

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/newton)

Reviewed: https://review.openstack.org/382574
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=d47dccfc6f02289f4a430795cb1eabc794915ae8
Submitter: Jenkins
Branch: stable/newton

commit d47dccfc6f02289f4a430795cb1eabc794915ae8
Author: Alexander Tivelkov <email address hidden>
Date: Wed Oct 5 19:52:46 2016 +0300

    'Forms:' section is now truly optional in ui definition

    The only mandatory section of the UI definition file is the
    "Application" block which defines the input object model snippet.
    Everything else is optional: the app developer may have no user input
    for their app besides its name.

    However, the UI was crashing if no 'Forms:' section is present. This
    has been fixed.

    Change-Id: Ie72770a8810369e2bff9a59e8f3845144032f080
    Closes-bug: #1630672

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano-dashboard 3.1.0

This issue was fixed in the openstack/murano-dashboard 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.