[dashboard] Password displaying mode breaks warnings

[Valerii Kovalchuk]

To reproduce:

Try to add some app with password field in UI to the environment. Proceed to app configuration page.

Scenario 1:
1. Click on the eye icon in the password field before typing any characters.
2. Start typing characters.
Warning message doesn't appear while it should.

Scenario 2:
1. Type any character to the password field, warning will appear.
2. Click on the eye icon.
3. Continue typing characters, satisfying password validation requirements.
Warning message doesn't change and doesn't disappear after entering valid password.

Changing password display mode in the process doesn't repair anything.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/333189

[Valerii Kovalchuk (vakovalchuk)]

It is worth mentioning that detecting the field to apply validation cannot rely neither on type of the field (because it changes on eye clicking) nor on the name of the field (because it can be anything depending on app developer choice).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Kirill Zaitsev (<email address hidden>) on branch: master
Review: https://review.openstack.org/333189
Reason: Abandoning, since the commit hasn't seen any movements for more than a month. Also the solution seems incorrect, since the names are dynamic and fixing a selector on a static field name would completely break the feature.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/368466

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/368466
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=d50cb35ece120b97a0c309d84dd2708c8c35c3ab
Submitter: Jenkins
Branch: master

commit d50cb35ece120b97a0c309d84dd2708c8c35c3ab
Author: Artem Tiumentcev <email address hidden>
Date: Sun Sep 11 20:37:53 2016 +0300

    Fix js validation of the password in dynamic UI

    Before this patch clicking on an eye icon disabled javascript
    validation of the password. I added to password field
    the attribute 'data-type=password' and in js changed
    the selector to include new attribute in the selector,
    that attaches the check function.

    Change-Id: Ic7e57814a68c315e570c120f31febdada73079a7
    Closes-Bug: #1567859

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/385848

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385848
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=b6ef0af8948aee4e39ed786db511ce9dfb409df5
Submitter: Jenkins
Branch: stable/newton

commit b6ef0af8948aee4e39ed786db511ce9dfb409df5
Author: Artem Tiumentcev <email address hidden>
Date: Sun Sep 11 20:37:53 2016 +0300

    Fix js validation of the password in dynamic UI

    Before this patch clicking on an eye icon disabled javascript
    validation of the password. I added to password field
    the attribute 'data-type=password' and in js changed
    the selector to include new attribute in the selector,
    that attaches the check function.

    Change-Id: Ic7e57814a68c315e570c120f31febdada73079a7
    Closes-Bug: #1567859
    (cherry picked from commit d50cb35ece120b97a0c309d84dd2708c8c35c3ab)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 3.1.0 release.