Update task in the Service Actions API references invalid Session State

[Felipe Monteiro]

Currently, the function update_task in murano.services.actions references the invalid variable 'states.SessionState.deploying'. However, the correct variable is 'states.SessionState.DEPLOYING' as defined in murano.services.states.

The following traceback is produced:

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "/opt/stack/mitaka-murano-gerrit/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
        return func(*args, **keywargs)
      File "murano/tests/unit/services/test_actions.py", line 88, in test_update_task
        mock_task, mock_unit)
      File "murano/services/actions.py", line 46, in update_task
        session.state = states.SessionState.deploying
    AttributeError: 'SessionState' object has no attribute 'deploying'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/380375

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/380397

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/380402

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/380407

[OpenStack Infra (hudson-openstack)]

Change abandoned by Felipe Monteiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/380407

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/380505

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380375
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=bf586063f3bc3c3c7f8970852b5234a49cde4aae
Submitter: Jenkins
Branch: master

commit bf586063f3bc3c3c7f8970852b5234a49cde4aae
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:19:01 2016 -0400

    Fix invalid SessionState.deploying reference in services actions.

    Currently, update_task in murano.services.actions references
    SessionState.deploying, which is invalid.

    Change-Id: Idab7138c877e10987e7edf2c3a845897b2219a93
    Closes-Bug: #1629361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380402
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=94f610a383bd2b0e0358bbb3fbb861d984f73cfd
Submitter: Jenkins
Branch: stable/mitaka

commit 94f610a383bd2b0e0358bbb3fbb861d984f73cfd
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:47:30 2016 -0400

    Fix invalid SessionState.deploying reference in services actions.

    Currently, update_task in murano.services.actions references
    SessionState.deploying, which is invalid.

    Change-Id: I414eacb323b5c905b5a76a871ab7f4df8751e9b9
    Closes-Bug: #1629361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380397
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=3365d22714366c327ea3427bb54ac7ca9e4ae5d5
Submitter: Jenkins
Branch: stable/newton

commit 3365d22714366c327ea3427bb54ac7ca9e4ae5d5
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 11:45:18 2016 -0400

    Fix invalid SessionState.deploying reference in services actions.

    Currently, update_task in murano.services.actions references
    SessionState.deploying, which is invalid.

    Change-Id: Ideab3cf42ffc525dc133d4e1f5307a09c2293511
    Closes-Bug: #1629361

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/381229

[OpenStack Infra (hudson-openstack)]

Change abandoned by Felipe Monteiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/381229
Reason: Redundant, see: https://review.openstack.org/#/c/380505/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380505
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=a278164ce2b1997f96093bebb7363c7fa707895f
Submitter: Jenkins
Branch: master

commit a278164ce2b1997f96093bebb7363c7fa707895f
Author: Felipe Monteiro <email address hidden>
Date: Fri Sep 30 15:03:01 2016 -0400

    Increase unit test coverage for Services Actions API.

    Commit includes:
    * Removed skip for test_update_task b/c related bug
      has been resolved.

    Implements bp: murano-unit-test-coverage
    Co-Authored-By: David Purcell <email address hidden>
    Co-Authored-By: Samantha Blanco <email address hidden>
    Co-Authored-By: Julian Sy <email address hidden>

    Change-Id: Iccae718d528d410afdd13cfd09cb385af7f2d338
    Related-Bug: #1629361

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano 3.1.0 release.