Should switch to get_notification_listener function for creating oslo.messaging server

Bug #1570127 reported by Kirill Zaitsev
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Angus Salkeld
Mitaka
Fix Committed
High
Kirill Zaitsev
Newton
Fix Released
High
Angus Salkeld

Bug Description

https://review.openstack.org/#/c/297988/ — this commit changes public interfaces of several classes in a backwards-incompatible way.
https://review.openstack.org/#/c/297988/9/oslo_messaging/notify/dispatcher.py here NotificationDispatcher used to accept 5 obligatory params and now it only accpets 3.
This would cause major problems for murano, since we use the library here https://github.com/openstack/murano/blob/master/murano/common/server.py#L231 and the change is backward-incompatible.
This would probably mean that the next release of oslo.messaging would be a major one, but nevertheless it would break murano code.

We should switch to using https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/listener.py#L186 get_notification_listener func, since oslo folks believe it would be left unchanged across major releases.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/305599

Changed in murano:
status: Confirmed → In Progress
summary: Should switch to get_notification_listener function for creating
- oslo.messaging serer
+ oslo.messaging server
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/305599
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=776a4ce2c00a9fafbce9888eaa99f162f2c43906
Submitter: Jenkins
Branch: master

commit 776a4ce2c00a9fafbce9888eaa99f162f2c43906
Author: Angus Salkeld <email address hidden>
Date: Thu Apr 14 10:38:22 2016 +1000

    Switch to using get_notification_listner

    Change-Id: Ied7acaeed6edde17d2d6f073c304021e22811409
    Closes-bug: #1570127

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307188

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/mitaka)

Reviewed: https://review.openstack.org/307188
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=5386c40d75dbe47cdf4a52de392198f323f02866
Submitter: Jenkins
Branch: stable/mitaka

commit 5386c40d75dbe47cdf4a52de392198f323f02866
Author: Angus Salkeld <email address hidden>
Date: Thu Apr 14 10:38:22 2016 +1000

    Switch to using get_notification_listner

    Change-Id: Ied7acaeed6edde17d2d6f073c304021e22811409
    Closes-bug: #1570127
    (cherry picked from commit 776a4ce2c00a9fafbce9888eaa99f162f2c43906)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 3.0.0.0b1

This issue was fixed in the openstack/murano 3.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2.0.1

This issue was fixed in the openstack/murano 2.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.