murano-agent sources contain non-free pre-built windows binary

[Thomas Goirand]

When building the Debian package for Liberty b3, I had the bad surprise to see this lintian output:

P: murano-agent source: source-contains-prebuilt-windows-binary contrib/windows-agent/Tools/NuGet.exe
N:
N: The source tarball contains a prebuilt binary for Microsoft Windows.
N: They are usually provided for the convenience of users. These files
N: usually just take up space in the tarball and are of no use in Debian.
N:
N: Check if upstream also provides source-only tarballs that you can use as
N: the upstream distribution instead. If not, you may want to ask upstream
N: to provide source-only tarballs.
N:
N: Severity: pedantic, Certainty: certain
N:
N: Check: cruft, Type: source

Please remove this pre-built .exe file from the Git. This makes the whole murano-agent non-free and will prevent from uploading it to Unix distributions like Debian and Fedora.

[Serg Melikyan (smelikyan)]

NuGet is licensed under Apache 2.0 https://github.com/NuGet/NuGetDocs/blob/master/License.txt

[Thomas Goirand (thomas-goirand)]

Serg,

Even if it is licensed under Apache 2.0, you should *not* put any files which are pre-built in a Git repository, or in release tarballs. We may have no way to build them in Debian for example. This could be a reason for murano-agent to be removed from Debian, which would be really bad, as the Murano images are Debian based.

If you need this, then put it in a separated project, like murano-agent-windows.

[Thomas Goirand (thomas-goirand)]

Guys, could we *please* have a solution for this *before* the final release of Liberty? Fixing the issue during the Mitaka cycle is not a valid solution.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228494

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/228498

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228494
Committed: https://git.openstack.org/cgit/openstack/murano-agent/commit/?id=5f5cb9282a89560f3f6daf22f52ed5631b7e3b92
Submitter: Jenkins
Branch: master

commit 5f5cb9282a89560f3f6daf22f52ed5631b7e3b92
Author: Stan Lagun <email address hidden>
Date: Mon Sep 28 18:18:20 2015 +0300

    NuGet.exe was removed from the repo

    Build instructions were added to README.rst

    Change-Id: I7d73d15764ac87c9cc37c0273b5b4a2200d99acb
    Closes-Bug: #1494844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228498
Committed: https://git.openstack.org/cgit/openstack/murano-agent/commit/?id=06cc634e5c7b1df24a9e9ab23badc57c4781ae28
Submitter: Jenkins
Branch: stable/liberty

commit 06cc634e5c7b1df24a9e9ab23badc57c4781ae28
Author: Stan Lagun <email address hidden>
Date: Mon Sep 28 18:18:20 2015 +0300

    NuGet.exe was removed from the repo

    Build instructions were added to README.rst

    Change-Id: I7d73d15764ac87c9cc37c0273b5b4a2200d99acb
    Closes-Bug: #1494844

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-agent 1.0.1 release.