[dashboard] filtering apps by category is broken when no apps belong to any category.

[Kirill Zaitsev]

To reproduce:

1) Upload several packages.
2) Make sure you have some categories defined and a category with no pkgs in it.
3) Create an environment
4) In the env component list view select a category with zero apps in it.
5) Select All in the same drop down.

Observed result: no apps, even though we chose All (or any category with apps in it)
Expected result: all apps should be displayed (or apps in the corresponding category)

NOTE: Filtering by categories, that have packages in them work as expected.

NOTE: The obvious user-friendly fix would be to show only categories that have at least one app in them. It's senseless to filter apps by category with 0 apps in it, from user standpoint.

------------------------------------------------

The category menu is not hidden after the desired category is selected. User gave to click somewhere to hide it.

[Anastasia Kuznetsova (akuznetsova)]

Same behavior with "Search":
1) Upload several packages.
2) Create an environment
3) In the env component list type something random to "Search" field and click on "Enter"
4) Type the name of one apps to the "Search" and click on "Enter"

Observed result:
Chosen app has to be shown
Actual result:
Nothing happened after step 4

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/200815

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/198659
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=8f5d984de5bfb13be8459a76af00b9c09de3caa3
Submitter: Jenkins
Branch: master

commit 8f5d984de5bfb13be8459a76af00b9c09de3caa3
Author: Li Xipeng <email address hidden>
Date: Sat Jun 27 17:51:04 2015 +0800

    Fix filtering apps by category is broken

    Div with id 'apps_carousel' will be hidden if a category with no apps belong to.
    As a result, filtering apps by category would be broken then even if selete apps
    with filter 'ALL'.

    Change-Id: I3467c63555ffd50d25c1d1428ce3c481a0de31fc
    Closes-Bug: #1454865

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/202972

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/202972
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=2ad85a3f38ee6ca0c9520691a3b94cc7be15432f
Submitter: Jenkins
Branch: stable/kilo

commit 2ad85a3f38ee6ca0c9520691a3b94cc7be15432f
Author: Li Xipeng <email address hidden>
Date: Sat Jun 27 17:51:04 2015 +0800

    Fix filtering apps by category is broken

    Div with id 'apps_carousel' will be hidden if a category with no apps belong to.
    As a result, filtering apps by category would be broken then even if selete apps
    with filter 'ALL'.

    Change-Id: I3467c63555ffd50d25c1d1428ce3c481a0de31fc
    Closes-Bug: #1454865

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/200815
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=bc03e821d84405f251ec33b422fb2600eaf5f29f
Submitter: Jenkins
Branch: master

commit bc03e821d84405f251ec33b422fb2600eaf5f29f
Author: Kirill Zaitsev <email address hidden>
Date: Sat Jul 11 12:59:06 2015 +0300

    Catalog: show package_count for categories.

    Filtering by a category, that does not contain any packages would result
    in an empty set of packages. We can prevent user from doing so, by
    disaplying number of packages in a category.
    This commit changes packages.categories to categories.list, that
    includes package_count information and outputs the information in the
    dropdown menu.
    This commit also sorts categories so that categories with packages
    are listed before categories without packages
    (both groups alphabetically ordered) for better ux.

    Change-Id: Ieaa0d64cd4bc703f4918fa41cb280288f76c2aa2
    Related-Bug: #1454865

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.