Repeatative HOT package uploads fail

Bug #1450547 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Alexander Tivelkov
Kilo
Fix Committed
Undecided
Kirill Zaitsev

Bug Description

Second and subsequent uploads of HOT-based packages fail until murano-api service is restarted

Seems like some yaql-related tags leak into the yaml loader and attempted to be applied to regular yaml files, which causes exceptions.

Changed in murano:
status: New → Confirmed
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179176

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/179176
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=779fd3cd2304c9276b65407372ccda6fa9a6b639
Submitter: Jenkins
Branch: master

commit 779fd3cd2304c9276b65407372ccda6fa9a6b639
Author: Alexander Tivelkov <email address hidden>
Date: Thu Apr 30 20:27:40 2015 +0300

    Fixed YAQL tag leakage to YAML loader

    Implicit yaml tag resolver being registered for YaqlYamlLoader (which is
    user to load MuranoPL classes as YAML documents with embedded YAQL
    statements) was being registered in the default YAML Dumper which is
    used for any YAML serialization.

    This was leading to inability to load more then one HOT-based package
    per API service lifetime: the first package which was uploaded was
    causing the leakage of YAQL statements into the global tag resolver.
    This global resolver was used for all subsequent load attempts, so plain
    yaml documents with Heat templates were attempted to be loaded as
    MuranoPL classes.

    This patch fixes this behavior by registering the implicit resolver
    without helper method (which actually registers the resolvers at default
    Dumper).

    Change-Id: Icd3b6d354bcb105c2c25f842ede077d539e9c246
    Closes-Bug: #1450547

Changed in murano:
status: In Progress → Fix Committed
tags: added: kilo-backport-potential
tags: added: juno-backport-potential
Changed in murano:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199109

no longer affects: murano/juno
tags: removed: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/199109
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=8617146b0fd02943b0bbf6f745a53e66e518c90d
Submitter: Jenkins
Branch: stable/kilo

commit 8617146b0fd02943b0bbf6f745a53e66e518c90d
Author: Alexander Tivelkov <email address hidden>
Date: Thu Apr 30 20:27:40 2015 +0300

    Fixed YAQL tag leakage to YAML loader

    Implicit yaml tag resolver being registered for YaqlYamlLoader (which is
    user to load MuranoPL classes as YAML documents with embedded YAQL
    statements) was being registered in the default YAML Dumper which is
    used for any YAML serialization.

    This was leading to inability to load more then one HOT-based package
    per API service lifetime: the first package which was uploaded was
    causing the leakage of YAQL statements into the global tag resolver.
    This global resolver was used for all subsequent load attempts, so plain
    yaml documents with Heat templates were attempted to be loaded as
    MuranoPL classes.

    This patch fixes this behavior by registering the implicit resolver
    without helper method (which actually registers the resolvers at default
    Dumper).

    Change-Id: Icd3b6d354bcb105c2c25f842ede077d539e9c246
    Closes-Bug: #1450547

tags: added: in-stable-kilo
Changed in murano:
milestone: liberty-1 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2015.1.1

This issue was fixed in the openstack/murano 2015.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/murano 2015.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.