dashboard - consider dropping use of floppyforms?

Bug #1805193 reported by Corey Bryant on 2018-11-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Medium
zhurong

Bug Description

Would it be possible to drop use of django-floppyforms from murano-dashboard? It doesn't seem to be very well supported anymore. Scrolling through the issues there are several unanswered for a long time [1] and there's not been a release in a long time [2]. This makes supporting the package in distros difficult in terms of support. The package was dropped from Ubuntu in Xenial (likely due to lack of use). In murano-dashboard, django-floppyforms was recently added to requirements.txt in commit caaa9ea88d163dc089c422d511c48ca93e9261f1, although it's use in the code appears to have been around for a while.

[1] https://github.com/gregmuellegger/django-floppyforms/issues
[2] https://github.com/gregmuellegger/django-floppyforms/releases

summary: - dashboard - consider dropping use of floppyfroms?
+ dashboard - consider dropping use of floppyforms?
Corey Bryant (corey.bryant) wrote :

I'm not sure this code is even used.

muranodashboard/common/widgets.py is the only module that imports from floppyforms, and floppyforms is used by class TriStateCheckboxSelectMultiple.

The only place TriStateCheckboxSelectMultiple is referenced is in muranodashboard/common/fields.py, in the TriStateMultipleChoiceField class.

However the TriStateMultipleChoiceField class never appears to be used. Here's a recursive grep through the murano-dashboard code:

murano-dashboard$ grep -r TriStateMultipleChoiceField
muranodashboard/common/fields.py:class TriStateMultipleChoiceField(forms.ChoiceField):

zhurong (zhu-rong) on 2019-02-26
Changed in murano:
status: New → Confirmed
importance: Undecided → Medium
zhurong (zhu-rong) wrote :

this is due to next part of the code haven't merged yet
https://review.openstack.org/#/c/168027/

Fix proposed to branch: master
Review: https://review.openstack.org/639482

Changed in murano:
assignee: nobody → zhurong (zhu-rong)
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers