py3.7 unit test failures

Bug #1786523 reported by Corey Bryant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
zhurong

Bug Description

There are async failures when running py3.7 tests.

  File "/usr/lib/python3/dist-packages/murano/tests/unit/test_heat_stack.py", line 201
    hs.push(async=True)
                ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/murano/engine/system/heat_stack.py", line 263
    def push(self, async=False):

async is now a keyword. A possible fix is changing all uses to async_.

https://docs.python.org/3/whatsnew/3.7.html

zhurong (zhu-rong)
Changed in murano:
importance: Undecided → Medium
assignee: nobody → zhurong (zhu-rong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/591142

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/591142
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=9fe87010f508b6f5bb8b862f81d92aed30280de0
Submitter: Zuul
Branch: master

commit 9fe87010f508b6f5bb8b862f81d92aed30280de0
Author: zhurong <email address hidden>
Date: Sat Aug 11 15:53:06 2018 +0800

    Fix py37 tests failed due to async

    Change-Id: If09cc4b27da22924e9ad5a5b930ccb0abcc84a34
    Closes-Bug: #1786523

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 7.0.0.0rc1

This issue was fixed in the openstack/murano 7.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.