Agent Listener unit tests do not properly override configuration

Bug #1634483 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Alexander Tivelkov

Bug Description

Agent Listener unit tests do not properly override configuration

Changed in murano:
importance: Undecided → Critical
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/387993

Changed in murano:
assignee: nobody → Alexander Tivelkov (ativelkov)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/387993
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=254202b98e6e3ec53750cde881b32196ca313ae5
Submitter: Jenkins
Branch: master

commit 254202b98e6e3ec53750cde881b32196ca313ae5
Author: Alexander Tivelkov <email address hidden>
Date: Wed Oct 19 15:45:16 2016 +0300

    Unblocking the gate

    Skipped test_deploy_app_with_volume_creation_from_backup test

    Tempest integration test is failing for volume creation from backup
    (reported as bug #1634876). To unblock the gate the appropriate test
    is skipped for now while the bug is being investigated.

    AgentListener unit test didn't properly override configuration, so in
    some circumstances it could be executed with the disabled murano agent
    which was leading to errors.

    At the same time AgentListener itself contained some legacy code
    leading to under-initialized state in case if the listener was
    disabled in config file.

    Related-bug: #1634876
    Change-Id: I5642b8017c61f77afb68463ba8eb3906eeae7225
    Closes-bug: #1634483

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.1.0

This issue was fixed in the openstack/murano 3.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano (stable/newton)

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/441477

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano (stable/newton)

Reviewed: https://review.openstack.org/441477
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=b4d301da4945db0f97c2dd773ae439b49b80bbd8
Submitter: Jenkins
Branch: stable/newton

commit b4d301da4945db0f97c2dd773ae439b49b80bbd8
Author: Stan Lagun <email address hidden>
Date: Fri Mar 3 13:11:17 2017 -0800

    AgentListener initialization was fixed

    When Murano Agent is disabled AgentListener was not
    initialized properly which caused deployment errors.

    This is partial backport of the
    https://review.openstack.org/#/c/387993/. That commit
    was supposed to fix tests that do not exist in Murano Newton
    and thus wasn't backported.

    Change-Id: I1a9f61c6b0020c6d3a5812f4d8ed519dc3cb7b44
    Closes-Bug: #1669903
    Related-bug: #1634483

tags: added: in-stable-newton
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.