TypeError thrown by wait_ready in System Engine Agent

[Felipe Monteiro]

In engine.system.agent.wait_ready, the wrong function call is made.

The call call(template, False, timeout) causes False() to be invoked, leading to the TypeError. It appears as if the function call_raw should instead be called.

The following sample traceback is produced:

Traceback (most recent call last):
  File "/opt/stack/mitaka-murano/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "murano/tests/unit/engine/system/test_agent.py", line 133, in test_is_ready
    self.assertTrue(self.agent.is_ready(1))
  File "murano/engine/system/agent.py", line 149, in is_ready
    self.wait_ready(timeout)
  File "murano/engine/system/agent.py", line 158, in wait_ready
    self.call(template, False, timeout)
  File "murano/engine/system/agent.py", line 127, in call
    plan = self.build_execution_plan(template, resources())
TypeError: 'bool' object is not callable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/386129

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/385989
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d80dfe2a7acae3ccf976276d758a6c7dea223ebc
Submitter: Jenkins
Branch: master

commit d80dfe2a7acae3ccf976276d758a6c7dea223ebc
Author: Felipe Monteiro <email address hidden>
Date: Thu Oct 13 14:32:52 2016 +0100

    Increase unit test coverage for Agent API.

    Implements bp: murano-unit-test-coverage

    Related-Bug: #1633176
    Change-Id: I4c560254ce0915339c1ab89e29318dbbade97593

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/386129
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=1e5a1cbf801cad83c9014e822393fb9daec5a988
Submitter: Jenkins
Branch: master

commit 1e5a1cbf801cad83c9014e822393fb9daec5a988
Author: Felipe Monteiro <email address hidden>
Date: Thu Oct 13 14:18:43 2016 -0400

    Fix TypeError being throw by wait_ready in Engine System Agent.

    Currently, wait_ready wrongly does call(template, False, timeout)
    but the second param is expected to be a ResourceManager, leading
    to the TypeError.

    This fix replaces the wrong function call with
    call_raw(template, timeout).

    Change-Id: I57e92eae95efc3e68b51ea751d08dd87946f85cb
    Closes-Bug: #1633176

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano 3.1.0 release.