Prevent unnecessary stack.push in Instance::releaseResources

Bug #1628905 reported by Konstantin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Wishlist
Konstantin

Bug Description

During the removal of the Environment with a lot of Instances, `releaseResources` called for each of the Instances. This causes push of new stack template (without next Instance) into Heat for each call. But stacks of each `CloudRegion` will be deleted, so we can skip each call of `push()`.
Thus entire `HeatStack::push()` operation is unnecessary.

Tags: core-library
Changed in murano:
status: New → In Progress
Revision history for this message
Valerii Kovalchuk (vakovalchuk) wrote :
Changed in murano:
status: In Progress → Confirmed
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/377972
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=510583ffff1c692d713a4f469bf72c45cde5f773
Submitter: Jenkins
Branch: master

commit 510583ffff1c692d713a4f469bf72c45cde5f773
Author: Snihyr Kostyantyn <email address hidden>
Date: Tue Sep 27 21:58:24 2016 +0300

    Prevent unnecessary stack.push in Instance::releaseResources

    All stack resources will be released if current CloudRegion object
    should be destroyed (isDoomed). There is no reason to push stack into Heat
    for each released instance.

    Change-Id: Id393d668e0c26c3fc47009f9dc68827618999397
    Closes-bug: #1628905

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.1.0

This issue was fixed in the openstack/murano 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.