Static actions can't work properly on semver <2.5.0

Bug #1626238 reported by Victor Ryzhenkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev
Newton
Fix Released
High
Kirill Zaitsev
Ocata
Fix Released
High
Kirill Zaitsev

Bug Description

{3} murano_tempest_tests.tests.api.application_catalog.test_static_actions.TestStaticActions.test_call_static_action_basic [0.247571s] ... FAILED
{3} murano_tempest_tests.tests.api.application_catalog.test_static_actions_negative.TestStaticActionsNegative.test_call_static_action_session_method [0.071140s] ... FAILED
{3} murano_tempest_tests.tests.api.application_catalog.test_static_actions_negative.TestStaticActionsNegative.test_call_static_action_wrong_class [0.073142s] ... FAILED
{3} murano_tempest_tests.tests.api.application_catalog.test_static_actions_negative.TestStaticActionsNegative.test_call_static_action_wrong_method [0.066435s] ... FAILED
{3} murano_tempest_tests.tests.api.application_catalog.test_static_actions_negative.TestStaticActionsNegative.test_call_static_action_wrong_package [0.072173s] ... FAILED

The root cause of this the semver == 2.3.7

The required is 2.5.0

Captured pythonlogging:
~~~~~~~~~~~~~~~~~~~~~~~
    2016-09-21 18:48:50,372 847 INFO [tempest.lib.common.rest_client] Request (TestStaticActionsNegative:test_call_static_action_session_method): 400 POST http://172.18.92.101:8082/v1/actions 0.065s
    2016-09-21 18:48:50,373 847 DEBUG [tempest.lib.common.rest_client] Request - Headers: {'Content-Type': 'application/json', 'Accept': 'application/json', 'X-Auth-Token': '<omitted>'}
            Body: {"classVersion": "=0", "className": "io.murano.apps.test_repository_class_11e29d8e", "packageName": null, "methodName": "staticNotAction", "parameters": {"myName": "John"}}
        Response - Headers: {'status': '400', 'content-length': '159', 'content-location': 'http://172.18.92.101:8082/v1/actions', 'date': 'Wed, 21 Sep 2016 18:48:50 GMT', 'content-type': 'text/plain; charset=UTF-8', 'connection': 'close', 'x-openstack-request-id': 'req-f426a118-e696-488d-8e29-091544c16583'}
            Body: 400 Bad Request

    The server could not comply with the request since it is either malformed or otherwise incorrect.

     Invalid requirement specification: u'=0'

Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: New → Confirmed
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374382

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/374384

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/374382
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=f691f3067efe3dd8e90f822558b147152af1bda1
Submitter: Jenkins
Branch: master

commit f691f3067efe3dd8e90f822558b147152af1bda1
Author: Kirill Zaitsev <email address hidden>
Date: Wed Sep 21 23:19:30 2016 +0300

    Convert =0 version specs to ==0 specs

    Murano is using semantic_version library for version specs. 2.3.1
    version of the library, which is the minimum allowed for newton does not
    treat '=0' as a valid spec, and requires '==0' (double equal signs).
    This issue went unnoticed, since there 2.5.0 version of the library
    allow both version spec, and it has been only discovered when, when
    tested against packaged version of the library.
    This commit converts any specs in format =\d.*
    into ==.d.* format, thus adding compatibility to 2.3.1 library.

    Closes-Bug: #1626238
    Change-Id: I68b50726a8b6547cc768452dcfc197e072a8e104

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/newton)

Reviewed: https://review.openstack.org/374384
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=6bb6702fe613bbfaf21497323cbe09aa08c900a8
Submitter: Jenkins
Branch: stable/newton

commit 6bb6702fe613bbfaf21497323cbe09aa08c900a8
Author: Kirill Zaitsev <email address hidden>
Date: Wed Sep 21 23:19:30 2016 +0300

    Convert =0 version specs to ==0 specs

    Murano is using semantic_version library for version specs. 2.3.1
    version of the library, which is the minimum allowed for newton does not
    treat '=0' as a valid spec, and requires '==0' (double equal signs).
    This issue went unnoticed, since there 2.5.0 version of the library
    allow both version spec, and it has been only discovered when, when
    tested against packaged version of the library.
    This commit converts any specs in format =\d.*
    into ==.d.* format, thus adding compatibility to 2.3.1 library.

    Closes-Bug: #1626238
    Change-Id: I68b50726a8b6547cc768452dcfc197e072a8e104

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.0.0.0rc2

This issue was fixed in the openstack/murano 3.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.0.0

This issue was fixed in the openstack/murano 3.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.1.0

This issue was fixed in the openstack/murano 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.