[devstack] shellcheck reports a lot of errors over devstack-plugin plugin.sh

Bug #1613692 reported by Kirill Zaitsev on 2016-08-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Medium
Unassigned

Bug Description

$ shellcheck plugin.sh -f gcc | wc -l
     168

$ shellcheck plugin.sh -f gcc | cut -d : -f 4- | sort | uniq -c
 156 note: Double quote to prevent globbing and word splitting. [SC2086]
   2 note: Use $(..) instead of legacy `..`. [SC2006]
   1 note: read without -r will mangle backslashes. [SC2162]
   2 warning: Declare and assign separately to avoid masking return values. [SC2155]
   1 warning: MURANO_PYTHONCLIENT_DIR appears unused. Verify it or export it. [SC2034]
   1 warning: Possible misspelling: MURANO_USE_GLARE may not be assigned, but murano_use_glare is. [SC2153]
   1 warning: Quote the rhs of = in [[ ]] to prevent glob matching. [SC2053]
   2 warning: Quote this to prevent word splitting. [SC2046]
   1 warning: Use cd ... || exit in case cd fails. [SC2164]
   1 warning: horizon_config_part appears unused. Verify it or export it. [SC2034]

These are mostly trivial errors and should be easy to fix.

Lin Yang (lin-a-yang) on 2016-08-31
Changed in murano:
assignee: nobody → Lin Yang (lin-a-yang)
Changed in murano:
milestone: newton-3 → newton-rc1

Fix proposed to branch: master
Review: https://review.openstack.org/364780

Changed in murano:
status: Confirmed → In Progress
Changed in murano:
milestone: newton-rc1 → newton-rc2
Changed in murano:
milestone: newton-rc2 → ocata-1
Lin Yang (lin-a-yang) on 2017-01-20
Changed in murano:
assignee: Lin Yang (lin-a-yang) → nobody

Change abandoned by Lin Yang (<email address hidden>) on branch: master
Review: https://review.openstack.org/364780
Reason: Conflict with others.

Changed in murano:
milestone: 3.1.0 → pike-2
Changed in murano:
status: In Progress → Triaged
Changed in murano:
milestone: pike-2 → pike-rc1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers