Murano

[agent] py34 gate tests are red, due to string comparison in json

Bug #1610181 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Kirill Zaitsev
Murano newton-3 "n3"

Bug Description

TestChefExecutor.test_create_nodejson_noatts and TestChefExecutor.test_create_nodejson do so. This can lead to false negatives if serialization would be different

Tags: agent tests
OpenStack Infra (hudson-openstack)
Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-agent (master)

Reviewed: https://review.openstack.org/345880
Committed: https://git.openstack.org/cgit/openstack/murano-agent/commit/?id=1673551ce751e993e7f3a2822b3fc86e8cbdd5eb
Submitter: Jenkins
Branch: master

commit 1673551ce751e993e7f3a2822b3fc86e8cbdd5eb
Author: Hidekazu Nakamura <email address hidden>
Date: Fri Jul 22 16:40:47 2016 +0900

    Chef executor unit tests now compare dicts instead of strings

    Before this patch tests used to compare json.dumps representation of
    dicts. This can lead to false negatives.
    This patch fixes to test to compare objects instead.

    Closes-Bug: #1610181
    Co-Authored-By: Kirill Zaitsev <email address hidden>
    Change-Id: I69af1c017362f95b92a81af3212f6520e7b4ceba

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano-agent 3.0.0.0b3

This issue was fixed in the openstack/murano-agent 3.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.