[logging] SSLMiddleware X-Forwarded-Proto debug output is excessive

Bug #1605806 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Low
Artem Tiumentcev

Bug Description

currently murano.api.middleware.ssl.SSLMiddleware logs a DEBUG line from every request even if it had not made the repalacement (i.e. there was no header). This is excessive and leads to log cluttering. It would be nice to only print the line to the log ONLY if the substitution occured, i.e. if the header and wsgi.url_scheme actually differ.

It might also be a good idea to promote this message to INFO in such case.

tags: added: api
Changed in murano:
milestone: newton-3 → newton-rc1
Revision history for this message
Artem Tiumentcev (darland-maik) wrote :

Hi, Kirill.
Can you tell me how to configure Murano in devstack to test this case and what actions need to do?
Thank you.

Changed in murano:
milestone: newton-rc1 → newton-rc2
Changed in murano:
milestone: newton-rc2 → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388721

Changed in murano:
assignee: nobody → Artem Tiumentcev (darland-maik)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/388721
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=1c14cc322e7b972f95e1b4ff181f934388bf0e41
Submitter: Jenkins
Branch: master

commit 1c14cc322e7b972f95e1b4ff181f934388bf0e41
Author: Artem Tiumentcev <email address hidden>
Date: Wed Oct 19 15:31:30 2016 +0300

    Fix debug output for SSLMiddleware X-Forwarded-Proto

    Before this patch debug output was excessive.
    Now print the line log if wsgi.url_scheme differ and

    Change-Id: I925a7dd0844dfa76696b75e9f818d1bb47b34928
    Closes-Bug: #1605806

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano 3.1.0

This issue was fixed in the openstack/murano 3.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.