Murano

[test-runner] TestRunner does not run setUp and tearDown if they are not overriden

Bug #1596509 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Alexander Tivelkov
Murano newton-2 "n2"

Bug Description

If the particular test fixture being run by a MuranoPL test-runner does not override setUp or tearDown methods, the base implementation of these methods do not get called.

Alexander Tivelkov (ativelkov)
Changed in murano:
assignee: nobody → Alexander Tivelkov (ativelkov)
milestone: none → newton-2
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334429

Changed in murano:
status: Confirmed → In Progress
Alexander Tivelkov (ativelkov)
summary: - [TestRunner] TestRunner does not run setUp and tearDown if they are not
+ [test-runner] TestRunner does not run setUp and tearDown if they are not
overriden
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/334429
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=63b75569b106f1a4728eb1e9b9448b148337c77b
Submitter: Jenkins
Branch: master

commit 63b75569b106f1a4728eb1e9b9448b148337c77b
Author: Alexander Tivelkov <email address hidden>
Date: Mon Jun 27 14:49:09 2016 +0300

    Test-runner now properly invokes setUp/tearDown methods

    Test-runner was looking only for the locally-defined methods (i.e.
    ignoring the inherited ones) when invoking service methods of test
    fixtures, such as 'setUp' and 'tearDown'. This caused incorrect
    behavior when these methods were defined in base classes of the actual
    fixtures.

    Change-Id: Ife4e4bed7e945093bb751da4ed0f8336c69c9065
    Closes-bug: #1596509

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/murano 3.0.0.0b2

This issue was fixed in the openstack/murano 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.