Murano

no warning message for empty env name with inline name edit

Bug #1571663 reported by zhurong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
zhurong
Murano newton-2 "n2"
Mitaka
Fix Committed
Medium
Kirill Zaitsev
Murano 2.0.x "2.0.x"
Newton
Fix Released
Medium
zhurong
Murano newton-2 "n2"

Bug Description

Steps:
- Go to "Application Catalog" -> "Environments"
- Move cursor to environment name and click icon "edit"
- Clear environment name field and click icon "save"

Expected result:
- Warning message that environment name can't be empty

Actual result:
- No notifications. Just environment name is still in edit mode

See original description
zhurong (zhu-rong)
Changed in murano:
assignee: nobody → zhurong (zhu-rong)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/307191

Changed in murano:
status: New → In Progress
Stan Lagun (slagun)
Changed in murano:
importance: Undecided → Medium
milestone: none → newton-1
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/307191
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=d5f9bce3f3ed5653132d13ecba517fd2a0540f6b
Submitter: Jenkins
Branch: master

commit d5f9bce3f3ed5653132d13ecba517fd2a0540f6b
Author: zhurong <email address hidden>
Date: Fri Apr 15 16:05:06 2016 -0400

    Added a warning message if environment name is empty

    Adding required=False to the environment name form allows it to call
    update_cell when it has been left empty. Added logic to update_cell
    to check if the form is empty or contains only whitespace and issue a
    warning if true and only if the form in question is called 'name'.

    Change-Id: I60eb475574be7713807fd0f5548a64b1f8c890c7
    Closes-Bug: #1571663

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/335256

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/mitaka)

Reviewed: https://review.openstack.org/335256
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=4d00cb0c5b38ecdf7d0fd1b02123f17fd2b26999
Submitter: Jenkins
Branch: stable/mitaka

commit 4d00cb0c5b38ecdf7d0fd1b02123f17fd2b26999
Author: zhurong <email address hidden>
Date: Fri Apr 15 16:05:06 2016 -0400

    Added a warning message if environment name is empty

    Adding required=False to the environment name form allows it to call
    update_cell when it has been left empty. Added logic to update_cell
    to check if the form is empty or contains only whitespace and issue a
    warning if true and only if the form in question is called 'name'.

    Change-Id: I60eb475574be7713807fd0f5548a64b1f8c890c7
    Closes-Bug: #1571663
    (cherry picked from commit d5f9bce3f3ed5653132d13ecba517fd2a0540f6b)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/murano-dashboard 3.0.0.0b2

This issue was fixed in the openstack/murano-dashboard 3.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/murano-dashboard 2.0.2

This issue was fixed in the openstack/murano-dashboard 2.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.