Error if binary file is included in plan template

[Nikolay Makhotkin]

Steps to reproduce:

1. Take murano package
2. Modify execution plan template:
  - include in it some binary file, e.g. archive (.zip, tar.gz)
3. Add appropriate file to Resources/scripts/
4. Deploy app

5. See error: '[exceptions.UnicodeDecodeError]: 'ascii' codec can't decode byte 0x8b in position 1: ordinal not in range(128)'

The error comes from method Resources.string https://github.com/openstack/murano/blob/master/murano/engine/system/agent.py#L290 and the main reason of the error - logging of result of a call to resources.string: logger doesn't support both unicode and str at a time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/297520

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmytro Dovbii (<email address hidden>) on branch: master
Review: https://review.openstack.org/297520

[Nikolay Starodubtsev (starodubcevna)]

Today I try to reproduce this bug on current master. Looks like it was fixed some time ago.

[Nikolay Starodubtsev (starodubcevna)]

I tried to reproduce it with this package

[Nikolay Makhotkin (nmakhotkin)]

The bug still exists. I checked it just a moment ago against master from 6th of September. Please reverify that using the following packages (in attachment), try to install HAProxy based LB.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/370093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370093
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=ce8e2ec37aefdd52a6953d9b1d55b2ce540fd2a2
Submitter: Jenkins
Branch: master

commit ce8e2ec37aefdd52a6953d9b1d55b2ce540fd2a2
Author: Valerii Kovalchuk <email address hidden>
Date: Wed Sep 14 15:18:40 2016 +0300

    Prevent logging of result of resources.string() method call

    The result of resources.string() method is the content of the file
    saved to string. Logging of binary file content causes
    UnicodeDecode error. Moreover, logging of any file content can be
    security issue. Finally, it is just not practical to fill the logs
    with tons of text from the big files.

    Change-Id: I87077b002f2a8888c22b4dfba1f7b9f0508fec69
    Closes-bug: #1561522

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/370576

[OpenStack Infra (hudson-openstack)]

Change abandoned by Valerii Kovalchuk (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/370576

[Valerii Kovalchuk (vakovalchuk)]

Restored https://review.openstack.org/#/c/370576/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/370576
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=0d3178cc41921a98f4a7ec6a4d49122337836f4d
Submitter: Jenkins
Branch: stable/mitaka

commit 0d3178cc41921a98f4a7ec6a4d49122337836f4d
Author: Valerii Kovalchuk <email address hidden>
Date: Wed Sep 14 15:18:40 2016 +0300

    Prevent logging of result of resources.string() method call

    The result of resources.string() method is the content of the file
    saved to string. Logging of binary file content causes
    UnicodeDecode error. Moreover, logging of any file content can be
    security issue. Finally, it is just not practical to fill the logs
    with tons of text from the big files.

    Change-Id: I87077b002f2a8888c22b4dfba1f7b9f0508fec69
    Closes-bug: #1561522
    (cherry picked from commit ce8e2ec37aefdd52a6953d9b1d55b2ce540fd2a2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano 3.0.0.0rc1 release candidate.