[env-templates] Public/private filters for environment templates doesn't work correctly

[Victor Ryzhenkin]

1. Create Public and Private templates in primary tenant
2. Create Private template in alt tenant
3. Make request to /v1/templates?is_public=true
4. Make sure, that all ok
5. Make request to /v1/templates?is_public=false using primary tenant

Expected: Only private templates returned

Actual: All templates, belongs to tenant is listed

Example:

{u'updated': u'2016-02-02T02:21:53', u'name': u'get_public_private_both_40107109', u'created': u'2016-02-02T02:21:53', u'tenant_id': u'd34f664a6a1c471da73cd56e957ba065', u'version': 0, u'is_public': True, u'id': u'bf38ddb166cb42f0972f47fe38d48de4'}, {u'updated': u'2016-02-02T02:21:53', u'name': u'get_public_private_both_9eb42eba', u'created': u'2016-02-02T02:21:53', u'tenant_id': u'd34f664a6a1c471da73cd56e957ba065', u'version': 0, u'is_public': False, u'id': u'b18128f589e94117954cab616c619ad1'}, {u'updated': u'2016-02-02T02:21:50', u'name': u'TestEnvironmentTemplates_5e0b4fb6', u'created': u'2016-02-02T02:21:50', u'tenant_id': u'd34f664a6a1c471da73cd56e957ba065', u'version': 0, u'is_public': True, u'id': u'3e1c9837cdee452bb13045ebbd3db3c0'}

[Victor Ryzhenkin (vryzhenkin)]

Hey, Lin! It's very cool, that you assigned bug to yourself! Thank you!
Some fruitful information about it:
 Code. that you need, located here: https://github.com/openstack/murano/blob/master/murano/api/v1/templates.py#L52

[Lin Yang (lin-a-yang)]

Hi Victor, thanks a lot for this information.

I assigned this to myself when found it's unassigned. Do you already working on this? If not, I will try to fix it.

[Victor Ryzhenkin (vryzhenkin)]

Lin, please, do! :)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/276782

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lin Yang (<email address hidden>) on branch: master
Review: https://review.openstack.org/276782
Reason: Combined this patch with https://review.openstack.org/#/c/277079/. Abandoned this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/277079
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=72cc7bf68edc900df50c06549e1206ef715e0cd0
Submitter: Jenkins
Branch: master

commit 72cc7bf68edc900df50c06549e1206ef715e0cd0
Author: Lin Yang <email address hidden>
Date: Sat Feb 6 21:14:30 2016 +0800

    Fix incorrect result of listing templates

    - When user executes 'murano env-template-list', it only returns all
      templates belong this tenant, and doesn't include public templates
      from other tenants.
    - It returns all templates belong to tenant when only requests
      private templates.

    Change-Id: I50f70f28827c851139f74cff3923843c3d48170b
    Closes-Bug: #1542626
    Closes-Bug: #1540709

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano 2.0.0.0b3 development milestone.