Murano

"#flake8: noqa" is using incorrectly

Bug #1540254 reported by Wang Bo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Chaozhe Chen
Murano
Fix Released
Undecided
Wang Bo
OpenStack Dashboard (Horizon)
Fix Released
Low
Wang Bo
OpenStack Dashboard (Horizon) mitaka-3 "m3"
Python client library for Sahara
Fix Released
Undecided
Bhagyashri Shewale
python-heatclient
Fix Released
Undecided
Wang Bo
python-novaclient
Fix Released
Undecided
Wang Bo

Bug Description

"# flake8: noqa" option disables all checks for the whole file. To disable one line we should use "# noqa".

Refer to: https://pypi.python.org/pypi/flake8
https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

Wang Bo (chestack)
Changed in horizon:
assignee: nobody → Wang Bo (chestack)
Wang Bo (chestack)
Changed in python-heatclient:
assignee: nobody → Wang Bo (chestack)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/274548

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/274558

Changed in horizon:
status: New → In Progress
Wang Bo (chestack)
Changed in python-novaclient:
assignee: nobody → Wang Bo (chestack)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/274637

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/274548
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=3298ad98c88309c0aab972284b2a403573224c94
Submitter: Jenkins
Branch: master

commit 3298ad98c88309c0aab972284b2a403573224c94
Author: Bo Wang <email address hidden>
Date: Mon Feb 1 16:32:12 2016 +0800

    Remove incorrectly used "# flake8: noqa"

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    Remove unused "# flake8: noqa" and fix hidden hacking errors.

    Change-Id: I624e96784ae7a22b5a5766f38bdf1fb8ade2d0a2
    Closes-Bug: #1540254

Changed in python-heatclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/274637
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=0105fd120659baf3445b994af29837755d155c73
Submitter: Jenkins
Branch: master

commit 0105fd120659baf3445b994af29837755d155c73
Author: Bo Wang <email address hidden>
Date: Mon Feb 1 20:17:47 2016 +0800

    Use # noqa to ignore one line but not whole file

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".

    Closes Bug: #1540254

    Change-Id: I34c8a2218f974cd7e78c60e9c1fec26751c4e82d

Changed in python-novaclient:
status: In Progress → Fix Released
Chaozhe Chen (chaozhe-chen)
Changed in designate:
assignee: nobody → Chaozhe Chen (chaozhe-chen)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/277924

Changed in designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/274558
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f94463bb53f8799882a8a2df6f92ea3195eb3fc6
Submitter: Jenkins
Branch: master

commit f94463bb53f8799882a8a2df6f92ea3195eb3fc6
Author: Bo Wang <email address hidden>
Date: Mon Feb 1 16:58:54 2016 +0800

    Switch to use "# noqa" correctly

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    switch to use "# noqa" and fix the hidden hacking issues.

    Change-Id: I1fe747da7a9ab345d0c84a8cb82a8243bf1ee761
    Closes-Bug: #1540254

Changed in horizon:
status: In Progress → Fix Released
Matthias Runge (mrunge)
Changed in horizon:
milestone: none → mitaka-3
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/277924
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=3873383df0347cbf27864733728462f74c7c46f0
Submitter: Jenkins
Branch: master

commit 3873383df0347cbf27864733728462f74c7c46f0
Author: Chaozhe.Chen <email address hidden>
Date: Wed Feb 10 00:10:03 2016 +0800

    Use "# noqa" instead of "#flake8: noqa"

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".

    This patch use "# noqa" instead of "#flake8: noqa" and fix some
    flake8 viilations.

    Change-Id: Ic9f7c82428728582cecf0fa40f288e9f20f5d5ca
    Closes-bug: #1540254

Changed in designate:
status: In Progress → Fix Released
Wang Bo (chestack)
Changed in murano:
assignee: nobody → Wang Bo (chestack)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/281778

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/281778
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=8b5fcdb21fe0f07e674498b31fcedfa831e8d068
Submitter: Jenkins
Branch: master

commit 8b5fcdb21fe0f07e674498b31fcedfa831e8d068
Author: Bo Wang <email address hidden>
Date: Thu Feb 18 19:37:56 2016 +0800

    Remove incorrectly used "# flake8: noqa"

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    Remove unused "# flake8: noqa" and fix hidden hacking errors.

    Change-Id: I8b26cb0e7e5ad4a838099c7aa3ced31b96f28ca2
    Closes-Bug: #1540254

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-heatclient 1.0.0

This issue was fixed in the openstack/python-heatclient 1.0.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b3

This issue was fixed in the openstack/horizon 9.0.0.0b3 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2.0.0.0b3

This issue was fixed in the openstack/murano 2.0.0.0b3 development milestone.

Bhagyashri Shewale (bhagyashri-shewale)
Changed in python-saharaclient:
assignee: nobody → Bhagyashri Shewale (bhagyashri-shewale)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-saharaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/332112

Changed in python-saharaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-saharaclient (master)

Reviewed: https://review.openstack.org/332112
Committed: https://git.openstack.org/cgit/openstack/python-saharaclient/commit/?id=9baa13e21716f194c17e755692cf5997e168f19a
Submitter: Jenkins
Branch: master

commit 9baa13e21716f194c17e755692cf5997e168f19a
Author: bhagyashris <email address hidden>
Date: Tue Jun 21 16:50:58 2016 +0530

    Remove incorrectly used "# flake8: noqa"

    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    Remove unused "# flake8: noqa" and fix hidden hacking errors.

    Closes Bug: #1540254

    Change-Id: I5c7f2f95038e0a26d1ebfb6a64aaae31b80ed5cc

Changed in python-saharaclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-troveclient 2.3.0

This issue was fixed in the openstack/python-troveclient 2.3.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/python-saharaclient 0.16.0

This issue was fixed in the openstack/python-saharaclient 0.16.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-cinderclient 1.6.0

This issue was fixed in the openstack/python-cinderclient 1.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-swiftclient 3.0.0

This issue was fixed in the openstack/python-swiftclient 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.