Floating IP is not assigned to instance

[Radek Pospisil]

devstack - murano at commit 08feb98be6ab49b9f0e80fc2ded185e2a273a749

Steps
* create environment with two applications, each has own instance. For instance check 'assign floating ip' checkbox
    - e.g., I'm using MySQL from https://git.openstack.org/cgit/stackforge/murano-apps/ . Just drag-n-drop two MySql applications and don't forget to check 'assign floating ip' for both instances.

* deploy the environment
* the check project instances - none of them have assigned floating ip.

IMO Commit https://git.openstack.org/cgit/stackforge/murano/commit/?id=2d5388a690a417eff9476c9d4889d42b4f964b7b caused that.

Here is environment json showing the error - note that assignfloatingip is True, but only 10.x.x.x IPs are assigned.

{
  "status": "ready",
  "updated": "2015-03-24T10:40:25",
  "networking": {},
  "name": "t1",
  "created": "2015-03-24T10:31:27",
  "tenant_id": "f7d6205f860447c79c218cebf3c5aa8e",
  "version": 2,
  "services": [
    {
      "username": "",
      "name": "MySqlDB1",
      "database": "",
      "instance": {
        "availabilityZone": "nova",
        "name": "blpqbi7n5xll11",
        "securityGroupName": null,
        "assignFloatingIp": true,
        "floatingIpAddress": null,
        "keyname": "cloud",
        "?": {
          "type": "io.murano.resources.LinuxMuranoInstance",
          "_actions": {},
          "id": "bf96f1e3-024b-49df-aa33-f6ddddef1c11"
        },
        "ipAddresses": [
          "10.0.15.3"
        ],
        "flavor": "m1.medium",
        "image": "17b13ed2-72c7-45a2-9986-8b2b6af4c253",
        "networks": {
          "useFlatNetwork": false,
          "primaryNetwork": null,
          "useEnvironmentNetwork": true,
          "customNetworks": []
        },
        "sharedIps": []
      },
      "password": "",
      "?": {
        "status": "ready",
        "_26411a1861294160833743e45d0eaad9": {
          "name": "MySQL"
        },
        "type": "io.murano.databases.MySql",
        "id": "b48ae141-b977-49ef-b9cd-c375d3198b9f",
        "_actions": {}
      }
    },
    {
      "username": "",
      "name": "MySqlDB2",
      "database": "",
      "instance": {
        "availabilityZone": "nova",
        "name": "rwuuwi7n5xuql2",
        "securityGroupName": null,
        "assignFloatingIp": true,
        "floatingIpAddress": null,
        "keyname": "cloud",
        "?": {
          "type": "io.murano.resources.LinuxMuranoInstance",
          "_actions": {},
          "id": "245648f8-b676-4455-8349-2fb31365beda"
        },
        "ipAddresses": [
          "10.0.15.4"
        ],
        "flavor": "m1.medium",
        "image": "17b13ed2-72c7-45a2-9986-8b2b6af4c253",
        "networks": {
          "useFlatNetwork": false,
          "primaryNetwork": null,
          "useEnvironmentNetwork": true,
          "customNetworks": []
        },
        "sharedIps": []
      },
      "password": "",
      "?": {
        "status": "ready",
        "_26411a1861294160833743e45d0eaad9": {
          "name": "MySQL"
        },
        "type": "io.murano.databases.MySql",
        "id": "0088adb1-90fe-40d2-bb7f-7ade54afc07d",
        "_actions": {}
      }
    }
  ],
  "id": "d700748999364f2280e3527d2424f003"
}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/167461

[Radek Pospisil (radek-pospisil)]

verified proposed fix - fix works correctly floating IPs are allocated as expected

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/167461
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=cc1d5eb5be01b8f5f7b9d630abc9292415d7d90f
Submitter: Jenkins
Branch: master

commit cc1d5eb5be01b8f5f7b9d630abc9292415d7d90f
Author: Stan Lagun <email address hidden>
Date: Wed Mar 25 03:52:53 2015 +0300

    Fixes instance FIP assignment

    YAQL expression for FIP resource were incorrect and left as is (as a string).
    Thus there were single resource for FIP with incorrect name instead of resource
    per VM

    Change-Id: Ieecdfdb0a7fbad82ef4344b4bac1a55656991e9e
    Closes-Bug: #1435787
    Closes-Bug: #1435961