Deadlock can happen if exception is thrown during deployment

Bug #1392102 reported by Stan Lagun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Stan Lagun
Juno
Fix Released
Critical
Stan Lagun

Bug Description

Murano engine holds method locks to prevent concurrent execution of the same method of the same object. If method execution ends with exception raised this locked is not released. If another thread (method) is was to wait for that lock it will end forever

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134078

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/134078
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=5cc02804902b78a83d2ee3a5698f4807a13ebde6
Submitter: Jenkins
Branch: master

commit 5cc02804902b78a83d2ee3a5698f4807a13ebde6
Author: Stan Lagun <email address hidden>
Date: Thu Nov 13 02:33:57 2014 +0300

    Fix method lock release upon exception

    Method lock was not released if method execution was ended
    with uncaught exception. As a result dead lock could occur.
    This commit moves lock release code into finally block

    Change-Id: Ie5794c55c9d5a30cd3255ac06e9af944eb732bb1
    Closes-Bug: #1392102

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135608

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/juno)

Reviewed: https://review.openstack.org/135608
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=c6712f8cc815fd998371c9ac10f2bdb1e0e5432e
Submitter: Jenkins
Branch: stable/juno

commit c6712f8cc815fd998371c9ac10f2bdb1e0e5432e
Author: Stan Lagun <email address hidden>
Date: Thu Nov 13 02:33:57 2014 +0300

    Fix method lock release upon exception

    Method lock was not released if method execution was ended
    with uncaught exception. As a result dead lock could occur.
    This commit moves lock release code into finally block

    Change-Id: Ie5794c55c9d5a30cd3255ac06e9af944eb732bb1
    Closes-Bug: #1392102
    (cherry picked from commit 5cc02804902b78a83d2ee3a5698f4807a13ebde6)

tags: added: in-stable-juno
Stan Lagun (slagun)
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
status: Fix Released → Fix Committed
milestone: none → 2014.2.1
milestone: 2014.2.1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.