[Dashboard] Need to rename 'Configuring' environment state

[Ekaterina Chernova]

When environment is created and seervicies added it has 'configuring' state
This is misleading. Need to create a new name for that state.

Moreover, this status is also applied after the deployment is finished and you open environment details - new session is opened and you add or remove applications from the environment. So "not deployed" is not the correct name.

Need to create something taht will be described the state between the environment creation and deployment start.

[Brian Tully (brian-tully)]

If it's something as simple as a language change, since the API returns status "pending" why not just have the status say "pending"?

Otherwise if we can piggyback on the current code in environments/api.py:

if not env.has_new_services and env.version == 0:
        if env.status == consts.STATUS_ID_READY:
            env.status = consts.STATUS_ID_NEW

Couldn't we also check to see if the env has new services but has yet to be deployed and if so set the status to pending or a new status something like STATUS_ID_READY_TO_DEPLOY

When is STATUS_ID_READY used?

[Ekaterina Chernova (efedorova)]

STATUS_ID_READY is correspond to 'ready' status of api, which means that there is no new pending applications in the environment.
It's either new, either deployed without errors.

So, do you suggest to rename Configuring (which corresponds to pending API status) to Ready to Deploy? or leave it Pending?

I suggest to rename just to "Configure' or to "Composition"

[Brian Tully (brian-tully)]

Thanks for the response Ekaterina :)

I think the ideal solution is one where the user clearly knows that he/she can perform an action like deploying. Currently the status says "Configuring" which is confusing as it leads one to believe that they need to wait until the configuring is completed, but there is no configuring occurring in the background. So when a user adds a component and the component is finished getting added, the API returns status "pending". The other statuses you suggested (Configure, Composition) are not ideal either as they are not clear (at least not in English). If the "pending" status means that the component has been added then I'd suggest we set the status to "Ready to deploy" or "Component added" to indicate the true state to the user that they can act on. "Configuring" makes the user think they need to wait for the configuring to finish before they can deploy, "Configure" makes the user think they need to click on the configure status and configure something before they can deploy (not true). "Ready to deploy" or "Component added" make the most sense to me.

What do you think?

[Ekaterina Chernova (efedorova)]

I vote for Ready to deploy because
1) Environment can be in pending state in case of component deleting. So 'Component added' doesn't suite, but 'ready to deploy' is good

2) It sounds similar to "Ready to configure", so it would be one style in naming.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/117270

[Brian Tully (brian-tully)]

I vote for "Ready to deploy" as well. "Ready to configure" is confusing because it leads a user to believe they need to or can further configure the component which is not the case. The status is getting inserted in a component row, so should relate to the component/service. If the component/service has been added and the api status returns "pending", then I think the status for the component should update to say "Ready to deploy" which clearly communicates to the user what the next step is.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/117270
Committed: https://git.openstack.org/cgit/stackforge/murano-dashboard/commit/?id=ab8159f8c2648f611974919f17100dddda62babe
Submitter: Jenkins
Branch: master

commit ab8159f8c2648f611974919f17100dddda62babe
Author: Ekaterina Fedorova <email address hidden>
Date: Wed Aug 27 19:05:29 2014 +0400

    Rename 'Configuring' state to 'Ready to deploy'

    'Configuring' is a confusing state since it implies
    that some process is running on the background.
    But that is not true.
    Status 'ready to deploy' indicates that deployment has not been started,
    but ready to begin after corresponding button will be pushed

    Change-Id: Ia3f0c9036aa989c974fb64563984324ace7bea41
    Closes-Bug: #1357220

[Brian Tully (brian-tully)]

So, I just noticed another related issue. When an environment/gets successfully deployed, the API still returns a status of "pending", so the dashboard will show a status of "Ready to deploy" even though it cannot be deployed again. So, unfortunately, I think we chose the wrong text to show as "pending" means more than just "ready to deploy". Either we need to update the API to return a different status than "pending" or we need to update the dashboard constants and change "Ready to deploy" to "Pending" or something else.

Should I open up a separate bug for this?

[Brian Tully (brian-tully)]

Here's a screenshot.

https://www.dropbox.com/s/l391le6xvazyeo7/pending-status-components.png?dl=0

Should you be able to deploy an environment multiple times?

Also, is it possible to update an environment status as "Deployed" if it has been deployed, or is the only option for the API to return "pending" as a status?

[Ekaterina Chernova (efedorova)]

Brain, please update code and try again. I deployed today and environment got status Ready until you add or remove apps.
After the deployment the old session has status deployed, and just open session has status pending. dashboard read status of the latest session.

[Brian Tully (brian-tully)]

Thanks Ekaterina. I updated code and tried again, and this time I did see the "Ready"status. I think what may have happened is that my session expired (I was asked to log in) and when I went back to the deployed environment, it no longer said "Ready", it said "Ready to deploy"