package loading makes repeat API calls

[Steve McLellan]

When the engine processes a job there are numerous API calls made (this is during an environment deletion, but i think the process is the same for any action):

GET http://localhost:8082/v1/catalog/packages?class_name=io.murano.Object&limit=20
GET http://localhost:8082/v1/catalog/packages/6aa15e97de5d45fd921b8ecd9a0bc173/download

Then, from principal_objects.py

http://localhost:8082/v1/catalog/packages?class_name=io.murano.Object&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.StackTrace&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.Exception&limit=20

Then from system_objects, these calls all result in 200 responses followed by "Error loading package %name" (because they're defined in code)

http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.AgentListener&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.Agent&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.NetworkExplorer&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.InstanceNotifier&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.HeatStack&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.StatusReporter&limit=20
http://localhost:8082/v1/catalog/packages?class_name=io.murano.system.Resources&limit=20

These classes are imported from code subsequently.

This results in 12 API calls when only 2 of them (the first two) have any effect. The package loader should be smarter and a) cache package information so it doesn't need to keep going to the API and b) don't make requests for packages that are defined in the engine code itself.

EDIT - this actually happens again once networking components are requested; I think at least 4 more requests are made for networking, then 2 or 3 more for security groups.

[Serg Melikyan (smelikyan)]

We need to improve our PackageLoader/PackageClassLoader

[ruhe (ruhe)]

https://review.openstack.org/#/c/113676