[api] marks environments deleted regardless of actual state

Bug #1325101 reported by Steve McLellan
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Serg Melikyan

Bug Description

When an environment is deleted it's immediately removed from the database; instead it should follow the same pattern as creation:
* Create a session in state 'deleting'
* Mark deployment state as 'deleting'
* Send RPC call
* On success, finally remove the environment

Primary reason for this is because it's much neater for the user, and in cases where users are being charged for resources, it could be extremely misleading to assume everything's been cleared up properly.

Changed in murano:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Serg Melikyan (smelikyan)
milestone: none → juno-1
Changed in murano:
assignee: Serg Melikyan (smelikyan) → Stan Lagun (slagun)
Stan Lagun (slagun)
Changed in murano:
milestone: juno-1 → juno-2
Changed in murano:
assignee: Stan Lagun (slagun) → nobody
Changed in murano:
importance: High → Critical
Changed in murano:
assignee: nobody → Serg Melikyan (smelikyan)
Stan Lagun (slagun)
Changed in murano:
assignee: Serg Melikyan (smelikyan) → Stan Lagun (slagun)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/109508

Changed in murano:
status: Confirmed → In Progress
ruhe (ruhe)
Changed in murano:
milestone: juno-2 → juno-3
Changed in murano:
assignee: Stan Lagun (slagun) → Serg Melikyan (smelikyan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/109508
Committed: https://git.openstack.org/cgit/stackforge/murano/commit/?id=56b2d5df276699c33b08298b6a592b8a1ebafe20
Submitter: Jenkins
Branch: master

commit 56b2d5df276699c33b08298b6a592b8a1ebafe20
Author: Stan Lagun <email address hidden>
Date: Fri Jul 25 11:06:56 2014 +0400

    Fixes silent deletion of environments

    Now environment deletion is done as a regular deployment that can fail.
    Environments that are deleted, but deletion process has failed remain in database
    and shown in dashboard with status 'delete failure'. Environments that are being deleted
    has status 'deleting' and do not disappear before they really got deleted on engine side

    Also improved status reporting for environments. Now it also reports status of last deployment -
    'deploy failure', 'delete failure'

    P.S. Functional tests were slightly refactored and fixed to reflect changes
    in deletion logic

    Change-Id: I05625dd71f7ca9559bb88319b26b122214f15019
    Closes-Bug: #1325101

Changed in murano:
status: In Progress → Fix Committed
ruhe (ruhe)
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.