Uniform approach in localization of log-strings should be used

Bug #1267514 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Ekaterina Chernova

Bug Description

Currently, part of log-message strings are localized, part are not. We should stick to the single approach: either localize all messages, or none of them.

In murano-api import _ from openstack common

Tags: verified
Revision history for this message
Timur Nurlygayanov (tnurlygayanov) wrote :

I suggest to localize all messages.

Changed in murano:
assignee: nobody → Timur Sufiev (tsufiev-x)
Changed in murano:
status: New → Fix Committed
milestone: none → 0.4.1
status: Fix Committed → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-api (release-0.4)

Fix proposed to branch: release-0.4
Review: https://review.openstack.org/68580

Changed in murano:
assignee: Timur Sufiev (tsufiev-x) → Ekaterina Fedorova (efedorova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-api (release-0.4)

Reviewed: https://review.openstack.org/68580
Committed: https://git.openstack.org/cgit/stackforge/murano-api/commit/?id=a63ff0a82e46080167e43c23c4749230a6ccc332
Submitter: Jenkins
Branch: release-0.4

commit a63ff0a82e46080167e43c23c4749230a6ccc332
Author: Ekaterina Fedorova <email address hidden>
Date: Thu Jan 23 13:36:23 2014 +0400

    Add translation support

    Use openstack.common.gettextutils for translation

    Closes-Bug: #1267514
    Change-Id: I4aaa9fae0b725bac724567a06387b6870c546ee5

Changed in murano:
status: In Progress → Fix Committed
tags: added: verified
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-api (master)

Reviewed: https://review.openstack.org/72378
Committed: https://git.openstack.org/cgit/stackforge/murano-api/commit/?id=968296bf7eebbb6b7bce3557e63fa99fceab900b
Submitter: Jenkins
Branch: master

commit 968296bf7eebbb6b7bce3557e63fa99fceab900b
Author: Ekaterina Fedorova <email address hidden>
Date: Mon Jan 20 13:01:37 2014 +0400

    Cherry-pick the following commits from release-0.4

    * Fix errors in infrastructure
     blueprinr one-style-config
     1) Update sample config - remove non-existing directory
     2) Add 0.4.1 version
     3) Rename config file to sample
     Fixes-Bug: 1270734

    * Catch AttributeError in case of incorrect session_id
     Closes-Bug: 1269749

    * Fixed issue with copy configuration files.
     Closes-Bug: #1271079

    * Add translation support

     Use openstack.common.gettextutils for translation
     Closes-Bug: #1267514

    * Fix name for syslog_log_facility param

    * Update requirements for a release-0.4.1

    * Handle incorrect env_id
     Closes-Bug: 1227154

    * Import _ not implicit

    Change-Id: I2744eaeef369220c5a8dabb027ba40622be9d155

Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.