Unnecessary log message when listing local services

[Walter Huf]

If the user connects to localhost:4949 and issues the "list" command without passing a hostname, the following message showed up my logs:

Use of uninitialized value $1 in lc at /usr/share/perl5/Munin/Node/Server.pm line 174, <STDIN> line 1.

To stop it, I changed line 174 in /usr/share/perl5/Munin/Node/Server.pm as follows:

- _list_services($session, lc($1));
+ _list_services($session, defined($1) ? lc($1) : undef);

[Daniel Hahler (blueyed)]

Upstream fix: http://munin-monitoring.org/changeset/4794

Index: /trunk/node/lib/Munin/Node/Server.pm
===================================================================
--- /trunk/node/lib/Munin/Node/Server.pm (revision 4770)
+++ /trunk/node/lib/Munin/Node/Server.pm (revision 4794)
@@ -168,5 +168,6 @@
     logger ("DEBUG: Running command '$_'.") if $config->{DEBUG};
     if (/^list\s*([0-9a-zA-Z\.\-]+)?/i) {
- _list_services($session, lc($1));
+ my $hostname_lc = defined($1) ? lc($1) : undef;
+ _list_services($session, $hostname_lc);
     }
     elsif (/^cap\s?(.*)/i) {

[Launchpad Janitor (janitor)]

This bug was fixed in the package munin - 2.0.0-1ubuntu1

---------------
munin (2.0.0-1ubuntu1) quantal; urgency=low

  * Resync with Debian unstable.
  * d/munin-node.upstart,munin.upstart: Add upstart configurations.

munin (2.0.0-1) unstable; urgency=medium

  * New upstream version. Roughly eight years after munin 1.0 there is now
    finally munin 2.0! See /usr/share/doc/munin/Announce-2.0 in the munin
    package for the full announcement. And/or previous debian/changelog
    entries too. Enjoy! And please report bugs, 2.0.1 shall be out soon.
    (Closes: #675153, #674148)
  * /etc/init/munin-node: chmod 755 /var/log/munin (Closes: #674747)
  * Make munin-node suggest munin-plugins-java and not munin-java-plugins.
  * Lower build-depends on debhelper to version 8. (Closes: #675209)

munin (2.0~rc6-3) unstable; urgency=low

  * Make munin-node depend on munin-plugins-core | munin-plugins.
    (Closes: #673124)
  * munin-node.logroate: create munin-node.log owned by root.
    (Closes: #606216)

munin (2.0~rc6-2) unstable; urgency=low

  * munin.postinst: Fix typo breaking the chgrp of $cgitempdir.

munin (2.0~rc6-1) unstable; urgency=low

  [ Holger Levsen ]
  * New upstream release candidate, quoting the upstream Changelog:
    - Many bugfixes in munin-cgi-graph:
      - if url parameters are not valid, send HTTP 404 instead of 500
      - move the generation of png via cgi under /var/lib/munin/cgi-tmp/
        (Closes: #668536)
      - don't cache URL with parameters anymore, and don't keep uncached URLs
        (Closes: #668667)
      - validate url characters (Closes: #668666)
      - add a max setting for cgi image size. (Closes: #670811)
    - Plugin fixes:
      - add explicit license for all plugins. (Closes: #670428)
      - hddtemp_smartctl: just use the device name as the labels
      - qmailscan: remove the use of tempfiles. (Closes: #668778)
  * munin.NEWS: document that "cgitmpdir /var/lib/munin/cgi-tmp" has to be
    set in munin.conf.
  * munin-node.postinst: chmod 755 /var/log/munin (Closes: #669230)
  * munin.postinst: make /var/lib/munin/cgi-tmp writable for group www-data.

  [ Matthias Schmitz ]
  * Add installation of apache configuration to /etc/apache2/conf-availble as
    needed by Apache 2.4. (Closes: #669816)

munin (2.0~rc5-3) unstable; urgency=low

  * Create /var/lib/munin/plugin-state in munin-node.postinst if it doesnt
    exist. (Closes: #668975)

munin (2.0~rc5-2) unstable; urgency=low

  [ Stig Sandbeck Mathisen ]
  * Handle removal of old statoverrides in a more robust fashion.
    (Closes: #668859)

munin (2.0~rc5-1) unstable; urgency=low

  [ Holger Levsen ]
  * New upstream release candidate, quoting the upstream Changelog:
     - Adding the current action to the command line. Useful for debugging.
     - Adding a new URL param full_size_mode to enable predictible IMG sizes
     - Enable sparklines with the url param "only_graph"
     - Start RRD just before first update. To avoid a very costly 1st update.
     - Emit the hosts in a sorted order, instead of somewhat random.
     - Do not emit png list if file handle is not defined. (Closes: #666759)
     - Add old option of --force-root, but with ...