GameFile client model class must not use java.io
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MUGLE |
Fix Released
|
Critical
|
Matt Giuca |
Bug Description
The GameFile client model class () has been broken on the client build since, I believe, trunk r54.1.30 (in the data-wrapper branch, now merged into trunk). GameFile depends upon classes in java.io, which are not available to GWT client code. Prior to r54.1.90, it depended upon java.io.File; after 54.1.90 it depends upon java.io.InputStream and java.io.
I think this is an example of where we can't just naively use these data wrapper objects around database objects. We need to consider the use of it on the client. GameFile's contents will only really be used in two situations: by a direct HTTP GET or a direct HTTP POST from an upload box. The GWT will not be involved and its javascript doesn't need access to those files. So they don't need to be exposed to the client at all.
Therefore, move them to GameFileData and don't expose them to client, and this should be solved. The public GameFile constructor can, for the moment, simply take no contents, and create an empty file (I don't think GameFiles will usually be constructed on the client).
Changed in mugle: | |
status: | Fix Committed → Fix Released |
This will be completly implemented by Tuesday (5/04/2011). There will also be a client service that lets users upload and download files.