unpacking mpackages stalls

[Ixokai]

In Mudlet 3.0 preview D, adding a mpackage on windows stalls. It just sits there saying 'unpacking...'

The easiest way to test is to just try to connect to GodWars 2 from the main GUI. It'll download a package and then just sit there.

However, I also ran into the problem when downloading a .mpackage from the forum, it just doesn't seem to unpack anything at all.

There's no error messages in the debug console.

[Stephen Lyons (slysven)]

Unfortunately, from what I recall there is a noted absence of error
handling in that bit - only some comments about conditions that ought to
be reported back to the user - but no code to do so. *Sigh*

[Vadim Peretokin (vperetokin)]

Yep - frequently run into this with users who have corrupted zips and etc,
always hangs for them.

On Thu, Jan 22, 2015 at 2:29 PM, Stephen Lyons <email address hidden>
wrote:

> Unfortunately, from what I recall there is a noted absence of error
> handling in that bit - only some comments about conditions that ought to
> be reported back to the user - but no code to do so. *Sigh*
>
> --
> You received this bug notification because you are a member of Mudlet
> Makers, which is subscribed to Mudlet.
> https://bugs.launchpad.net/bugs/1413069
>
> Title:
> unpacking mpackages stalls
>
> Status in Mudlet the MUD client:
> Confirmed
>
> Bug description:
> In Mudlet 3.0 preview D, adding a mpackage on windows stalls. It just
> sits there saying 'unpacking...'
>
> The easiest way to test is to just try to connect to GodWars 2 from
> the main GUI. It'll download a package and then just sit there.
>
> However, I also ran into the problem when downloading a .mpackage from
> the forum, it just doesn't seem to unpack anything at all.
>
> There's no error messages in the debug console.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1413069/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~mudlet-makers
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~mudlet-makers
> More help : https://help.launchpad.net/ListHelp
>

[Vadim Peretokin (vperetokin)]

Update from Stephen:

In passing I have had some joy in improving package installation as mentioned in bug 1413069 - it seems that not all archive production programs follow the step of including a zip archive entry (of zero file size) with a name ending in '/' to indicate a (sub)directory in the archive - I have successfully overcome that problem by scanning through all the entries looking both for those entries and for filenames containing '/' in places other than the first or last character. After creating any destination paths needed for those sub-directories I have then been able to extract all the contents required on a second pass. I only found out about this happening when I had put error messages (using Host::mTelnet.postMessage) up on the main console, so I do have a fix for this but it needs further work to put in error handling all the way through the file handling stuff in all of Host's methods and other relevant classes....

[Vadim Peretokin (vperetokin)]

This is sitll an issue present in 3.0.0-epsilon.

[Vadim Peretokin (vperetokin)]

https://github.com/Mudlet/Mudlet/pull/345 fixes the test case provided here.

[Stephen Lyons (slysven)]

Though importantly it does NOT add error messages - that will require a further, probably separate PR...

[Stephen Lyons (slysven)]

The release_30 version https://github.com/Mudlet/Mudlet/pull/360 has been merged into the codebase - so the unpacking should no longer stall - again I remark that the code is still greatly under-equipped with error handling messages so that the user may not realised that something has failed even though the unpacking message DOES now go away on error.

[Stephen Lyons (slysven)]

Whilst this was an element of https://bugs.launchpad.net/mudlet/+bug/1254364 the latter is not IMHO a duplicate of this bug and so I have undone that linkage.

[Vadim Peretokin (vperetokin)]

I think they'll realise it when the package doesn't get installed.

On Mon, Dec 19, 2016 at 4:55 PM Stephen Lyons <email address hidden>
wrote:

> The release_30 version https://github.com/Mudlet/Mudlet/pull/360 has
> been merged into the codebase - so the unpacking should no longer stall
> - again I remark that the code is still greatly under-equipped with
> error handling messages so that the user may not realised that something
> has failed even though the unpacking message DOES now go away on error.
>
> ** Changed in: mudlet
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1254364).
> https://bugs.launchpad.net/bugs/1413069
>
> Title:
> unpacking mpackages stalls
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1413069/+subscriptions
>