Custom exit lines - closing the dialog via 'X' creates some kind of an exits line

[Vadim Peretokin]

Right-click on a room, select 'Custom exit lines', then hit the X (not Cancel) to close the dialog. Right-click on the room again and the menu to finish a custom exit line will show - when none was being created.

[Stephen Lyons (slysven)]

Confirmed, should be able to fix by "wiring-up" the dialog's close button to the Cancel one...

[Stephen Lyons (slysven)]

Fix proposed: https://github.com/Mudlet/Mudlet/pull/215

[Stephen Lyons (slysven)]

Fix merged into Mudlet/development branch.

[Vadim Peretokin (vperetokin)]

This wasn't merged into release_30 so it's still a bug in there. I tried cherrypicking, but that brought in a whole lot of other changes that happened on develop since then unlike what I expected.

I'm not sure if it's worthwhile to manually move the changes across or just wait until we do The Merge?

[Vadim Peretokin (vperetokin)]

Re-opening as it also fixes a crashing bug and we'd like that fixed in 3.0. Doesn't make sense to make a release with a known crashing bug and a fix lined up for it.

[Stephen Lyons (slysven)]

Well, if the "Map Auditing" went into the release_30 then I think the bugged data (custom line data items in the TRoom class with a empty string as the "key" in the various structures) should get cleared out when reloaded if it does get saved. Worth checking to see whether such a line created can be selected AND deleted from the 2D map GUI - which would make it an annoyance or whether it provokes a crash - which would make it a more serious problem...

[Vadim Peretokin (vperetokin)]

Okay - how do you think we should get the fix into release_30 though?
Cherrypicking... doesn't do what it says in the manual, it tries to pull
across more changes than just that one commit you made on development. I
guess our only option is to manually copy the changes across? I'm happy to
do that, just deciding on the best option here.

On Mon, Mar 20, 2017 at 2:45 PM Stephen Lyons <email address hidden>
wrote:

> Well, if the "Map Auditing" went into the release_30 then I think the
> bugged data (custom line data items in the TRoom class with a empty
> string as the "key" in the various structures) should get cleared out
> when reloaded if it does get saved. Worth checking to see whether such a
> line created can be selected AND deleted from the 2D map GUI - which
> would make it an annoyance or whether it provokes a crash - which would
> make it a more serious problem...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1369041
>
> Title:
> Custom exit lines - closing the dialog via 'X' creates some kind of an
> exits line
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1369041/+subscriptions
>

[Vadim Peretokin (vperetokin)]

The concern here is introduce least pain for The Merge that's coming up
(which looks really painful, by the way).

On Mon, Mar 20, 2017 at 2:47 PM Vadim Peretokin <email address hidden>
wrote:

> Okay - how do you think we should get the fix into release_30 though?
> Cherrypicking... doesn't do what it says in the manual, it tries to pull
> across more changes than just that one commit you made on development. I
> guess our only option is to manually copy the changes across? I'm happy to
> do that, just deciding on the best option here.
>
> On Mon, Mar 20, 2017 at 2:45 PM Stephen Lyons <email address hidden>
> wrote:
>
> Well, if the "Map Auditing" went into the release_30 then I think the
> bugged data (custom line data items in the TRoom class with a empty
> string as the "key" in the various structures) should get cleared out
> when reloaded if it does get saved. Worth checking to see whether such a
> line created can be selected AND deleted from the 2D map GUI - which
> would make it an annoyance or whether it provokes a crash - which would
> make it a more serious problem...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1369041
>
> Title:
> Custom exit lines - closing the dialog via 'X' creates some kind of an
> exits line
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mudlet/+bug/1369041/+subscriptions
>
>

[Vadim Peretokin (vperetokin)]

I will copy the patch across to release_30.

[Vadim Peretokin (vperetokin)]

PR: https://github.com/Mudlet/Mudlet/pull/432