Global gSysMessage leaks messages between profiles

[Stephen Lyons]

Current Git code (at least) uses a global QStringList qSysMesssages to hold initialisation messages (both Ok and Error types) from the Lua subsystem (TLuaInterpreter) and from the Server connection process (cTelnet) unfortunately the code in cTelnet::connectIt() cannot tell from which profile/host instance the messages originated and does not explicitly remove them.

This means that upon starting up a second profile in a Mudlet instance messages from the first profile are shown.

Code that removes duplicate messages merely confuses the information displayed with the result that if a problem has been fixed between the first and second profiles being started it is possible to get an "Error" message from the first and then an "Ok" for the same module from the second.

I have coded a fix at my branch mudletDev_fileLocation_debugControls on my GitHub repository https://github.com/SlySven/Mudlet2/tree/mudletDev_fileLocation_debugControls which tracks Chris's mudletDev repository on GH, it is down as pull request #35 to that: https://github.com/Chris7/Mudlet2/pull/35.

As a highly contrived example I un-installed all the external non-Mudlet Lua modules that Mudlet uses and started up the Mudlet instance, I fired up one profile, then loading in just my distribution's lua-filesystem package, and then started a second profile before taking a composite screen shot (it took more than one screen to show all the text!) that is attached here. This is the output from the current mudletDev branch code.

[Stephen Lyons (slysven)]

Blast, got my branches confused I MEANT TO SAY my mudletDev_fixGSysMessage branch at https://github.com/SlySven/Mudlet2/tree/mudletDev_fixGSysMessage. And this is the same output from it.

[Stephen Lyons (slysven)]

Note that there was an issue in that the error strings from the lua interpreter started some lines with a tab character which was messing up the pre-fix display (text was spilling over onto colored background part of screen). The pre-fix shot shows both an Error message and an OK one for the "lfs" lua file system module!

There is an additional separate problem which I am not skilled enough to address I've posted in bug report https://bugs.launchpad.net/mudlet/+bug/1310372